Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751012AbaKWFWU (ORCPT ); Sun, 23 Nov 2014 00:22:20 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:51338 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750702AbaKWFWS (ORCPT ); Sun, 23 Nov 2014 00:22:18 -0500 Date: Sun, 23 Nov 2014 00:22:00 -0500 (EST) From: Pankaj Gupta To: "Michael S. Tsirkin" , David Miller Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jasowang@redhat.com, dgibson@redhat.com, vfalico@gmail.com, edumazet@google.com, vyasevic@redhat.com, hkchu@google.com, wuzhy@linux.vnet.ibm.com, xemul@parallels.com, therbert@google.com, bhutchings@solarflare.com, xii@google.com, stephen@networkplumber.org, jiri@resnulli.us, sergei shtylyov Message-ID: <1279921267.2842813.1416720120277.JavaMail.zimbra@redhat.com> In-Reply-To: <20141119204427.GB30994@redhat.com> References: <1416327778-17716-1-git-send-email-pagupta@redhat.com> <20141119.151628.768548269128919029.davem@davemloft.net> <20141119204427.GB30994@redhat.com> Subject: Re: [PATCH net-net 0/4] Increase the limit of tuntap queues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF23 (Linux)/8.0.6_GA_5922) Thread-Topic: Increase the limit of tuntap queues Thread-Index: 8iMeCK7d6zv6oQiYJAWiIK+uxvQSTQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, Nov 19, 2014 at 03:16:28PM -0500, David Miller wrote: > > From: Pankaj Gupta > > Date: Tue, 18 Nov 2014 21:52:54 +0530 > > > > > - Accept maximum number of queues as sysctl param so that any user space > > > application like libvirt can use this value to limit number of queues. > > > Also > > > Administrators can specify maximum number of queues by updating this > > > sysctl > > > entry. > > > > This is the only part I don't like. > > > > Just let whoever has privileges to configure the tun device shoot > > themselves in the foot if they want to by configuring "too many" > > queues. > > > > If the virtual entity runs itself out of resources by doing something > > stupid, it's purely their problem. We can configure some fixed number of queues like 16 or so at the start if multiqueue is enabled and then if somebody needs more then that, they can do on their own. If we dont want anyone to directly increase the number of queues, we can add an ioctl command for increasing number of queues? Suggestions here. > > Well it will run host out of kernel, no? > > -- > MST > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/