From: "Xue, Ken" <Ken.Xue@amd.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: "lenb@kernel.org" <lenb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Wu, Jeff" <Jeff.Wu@amd.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Andriy Shevchenko <andriy.shevchenko@intel.com>
Subject: RE: [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86
 system.
Thread-Topic: [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86
 system.
Thread-Index: AQHQAvYgXIrCrtqy70GE81FMEpghO5xufEOAgACAwSA=
Date: Mon, 24 Nov 2014 01:02:30 +0000
Message-ID: <4AC89B18A26BAB43B540DB1C94E2802C05A48D06@scybexdag03.amd.com>
References: <1416290291-5802-1-git-send-email-Ken.Xue@amd.com>
 <20864469.6Ozf1NSibZ@vostro.rjw.lan>
In-Reply-To: <20864469.6Ozf1NSibZ@vostro.rjw.lan>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit


On Tuesday, November 18, 2014 01:58:11 PM Ken Xue wrote:
> This new feature is to interpret AMD specific ACPI device to platform 
> device such as I2C, UART found on AMD CZ and later chipsets. It is 
> based on example INTEL LPSS. Now, it can support AMD I2C & UART.
> 
> Signed-off-by: Ken Xue <Ken.Xue@amd.com>
> Signed-off-by: Jeff Wu <Jeff.Wu@amd.com>

Generally speaking, this seems to duplicate much code from acpi_lpss which should be re-used instead.  What about moving the code that will be common between acpi_lpss and the new driver into a new file (say acpi_soc.c)?

Also, you need to avoid automatic creation of platform devices when !X86_AMD_PLATFORM_DEVICE in analogy with what acpi_lpss does, or bad things will happen.

[ken] sounds fair enough.  Let me take action to merge drivers to acpi_soc.c ? or you have other plan?

[...]
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?