Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751081AbaKXFA0 (ORCPT ); Mon, 24 Nov 2014 00:00:26 -0500 Received: from mail-qc0-f180.google.com ([209.85.216.180]:49725 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbaKXFAU (ORCPT ); Mon, 24 Nov 2014 00:00:20 -0500 MIME-Version: 1.0 In-Reply-To: References: <1416576954-11997-1-git-send-email-gautam.vivek@samsung.com> <1416576954-11997-2-git-send-email-gautam.vivek@samsung.com> Date: Mon, 24 Nov 2014 10:30:19 +0530 Message-ID: Subject: Re: [PATCH 01/11] pinctrl: exynos: Add BUS1 pin controller for exynos7 From: Vivek Gautam To: Alim Akhtar Cc: Vivek Gautam , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Linux USB Mailing List , "devicetree@vger.kernel.org" , Felipe Balbi , kishon , "linux-omap@vger.kernel.org" , Greg KH , Tomasz Figa , Sylwester Nawrocki , "robh+dt" , Alan Stern , Kukjin Kim , Linus Walleij Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alim, On Sat, Nov 22, 2014 at 7:07 PM, Alim Akhtar wrote: > Hi Vivek, > > On Fri, Nov 21, 2014 at 7:05 PM, Vivek Gautam wrote: >> USB and Power regulator on Exynos7 require gpios available >> in BUS1 pin controller block. >> So adding the BUS1 pinctrl support. >> >> Signed-off-by: Naveen Krishna Ch >> Signed-off-by: Vivek Gautam >> Cc: Linus Walleij >> --- >> drivers/pinctrl/samsung/pinctrl-exynos.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c >> index d5d4cfc..caca5b5 100644 >> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c >> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c >> @@ -1300,6 +1300,13 @@ static const struct samsung_pin_bank_data exynos7_pin_banks7[] __initconst = { >> EXYNOS_PIN_BANK_EINTG(8, 0x060, "gpr3", 0x0c), >> }; >> >> +/* pin banks of exynos7 pin-controller - BUS1 */ >> +static const struct samsung_pin_bank_data exynos7_pin_banks8[] __initconst = { >> + EXYNOS_PIN_BANK_EINTG(8, 0x020, "gpf0", 0x00), >> + EXYNOS_PIN_BANK_EINTG(8, 0x0a0, "gpf4", 0x10), >> + EXYNOS_PIN_BANK_EINTG(6, 0x120, "gph1", 0x20), >> +}; >> + > Looks like you are just trying to touch pin banks only related to USB > stuffs, but as this patch does not have any dependencies on other > patches in this series, will you consider adding other pin banks of > BUS1, just for completeness of BUS1 pin-controller. True, this just touches the USB related pinctrl. Will add the rest pin banks of BUS1 for completeness. Thanks for pointing out. :-) [snip] -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/