Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbaKXMRz (ORCPT ); Mon, 24 Nov 2014 07:17:55 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:56888 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbaKXMRw (ORCPT ); Mon, 24 Nov 2014 07:17:52 -0500 Message-ID: <547321A2.6010207@ti.com> Date: Mon, 24 Nov 2014 17:46:34 +0530 From: Vignesh R User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Sebastian Andrzej Siewior CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King , Jonathan Cameron , Hartmut Knaack , , Dmitry Torokhov , Lee Jones , Lars-Peter Clausen , Peter Meerwald , Samuel Ortiz , Felipe Balbi , Brad Griffis , Sanjeev Sharma , Paul Gortmaker , Jan Kardell , , , , , , Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes References: <1415941651-28962-1-git-send-email-vigneshr@ti.com> <20141124115116.GA14997@linutronix.de> In-Reply-To: <20141124115116.GA14997@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 24 November 2014 05:21 PM, Sebastian Andrzej Siewior wrote: > * Vignesh R | 2014-11-14 10:37:25 [+0530]: > >> This series of patches fix TSC defects related to lag in touchscreen >> performance and cursor jump at touch release. The lag was result of >> udelay in TSC interrupt handler. Cursor jump due to false pen-up event. >> The patches implement Advisory 1.0.31 in silicon errata of am335x-evm > am335x not -evm. The am335x-evm is a board (with its own advisory > document) built around the SoC. > > Just testing the v4. I can use now IIO and touchscren at the same time. > back at v1 I reported that it does not work, this has been fixed now. > I had it running for a few minutes, now I see one of WARN_ON() beeing > triggered (I've cut a few numbers so don't wonder about PID 2 and so on): > > |dmesg |grep WARNING | wc -l > |10 > | dmesg |grep WARNING > |[306.257995] WARNING: CPU: 0 PID: 97 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[365.469591] WARNING: CPU: 0 PID: 58 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[379.255904] WARNING: CPU: 0 PID: 24 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[426.230505] WARNING: CPU: 0 PID: 35 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[435.654091] WARNING: CPU: 0 PID: 28 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[438.897519] WARNING: CPU: 0 PID: 91 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[525.720193] WARNING: CPU: 0 PID: 88 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[527.644770] WARNING: CPU: 0 PID: 38 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[557.218349] WARNING: CPU: 0 PID: 56 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > |[610.077274] WARNING: CPU: 0 PID: 2 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104 > > The complete trace: > > |[610.110692] CPU: 0 PID: 4422 Comm: cat Tainted: G W 3.18.0-rc6+ #1745 > |[610.118577] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > |[610.126772] [] (show_stack) from [] (warn_slowpath_common+0x68/0x88) > |[610.135313] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) > |[610.144586] [] (warn_slowpath_null) from [] (am335x_tsc_se_set_once+0xf8/0x104 [ti_am335x_tscadc]) > |[610.155886] [] (am335x_tsc_se_set_once [ti_am335x_tscadc]) from [] (tiadc_read_raw+0xbc/0x190 [ti_am335x_adc]) > |[610.168326] [] (tiadc_read_raw [ti_am335x_adc]) from [] (iio_read_channel_info+0x9c/0xa4 [industrialio]) > |[610.180191] [] (iio_read_channel_info [industrialio]) from [] (dev_attr_show+0x1c/0x48) > |[610.190477] [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x8c/0x110) > |[610.199108] [] (sysfs_kf_seq_show) from [] (kernfs_seq_show+0x24/0x28) > |[610.207833] [] (kernfs_seq_show) from [] (seq_read+0x1b4/0x47c) > |[610.215922] [] (seq_read) from [] (vfs_read+0x8c/0x148) > |[610.223269] [] (vfs_read) from [] (SyS_read+0x40/0x8c) > |[610.230525] [] (SyS_read) from [] (ret_fast_syscall+0x0/0x30) > > Could you please look at that one? (I tested it on am335x-evm btw). I have tried running both IIO and TSC at the same time. But I have never seen WARN_ON() even after running for close to 30 min. Can you send me the exact script, so that it will be easy to reproduce? Regards Vignesh > > Sebastian > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/