Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343AbaKXRxr (ORCPT ); Mon, 24 Nov 2014 12:53:47 -0500 Received: from mail-wg0-f46.google.com ([74.125.82.46]:65048 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbaKXRxp (ORCPT ); Mon, 24 Nov 2014 12:53:45 -0500 Message-ID: <547370A4.3070707@redhat.com> Date: Mon, 24 Nov 2014 18:53:40 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel,gmane.comp.emulators.kvm.devel To: Nadav Amit CC: Linux Kernel Mailing List , kvm list , Nadav Amit , Wanpeng Li Subject: Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host References: <1416594678-13011-1-git-send-email-pbonzini@redhat.com> <547318E5.8070408@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/11/2014 16:28, Nadav Amit wrote: > > Since kvm_load_guest_fpu is called before the guest_fpu is ever stored, there are 2 more problems that currently cause #GP: > 1. XCOMP_BV[63] = 0 > 2. XSTATE_BV sets a bit (including bit 63) that is not set in XCOMP_BV (XCOMP_BV is initialised to zero). > > [see SDM 13.11 "OPERATION OF XRSTORS”] > > Once I initialise XCOMP_BV to (1ull << 63) | XSTATE_BV, the guest runs successfully. > I have not checked any other qemu functionality that might be affected by the patch. I posted patches that assume that QEMU calls KVM_SET_XSAVE early enough. If this is not the case, can you cook up and post a patch to kvm_arch_vcpu_init that fixes the remaining problem? Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/