Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607AbaKXSI5 (ORCPT ); Mon, 24 Nov 2014 13:08:57 -0500 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:8530 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753598AbaKXSIz (ORCPT ); Mon, 24 Nov 2014 13:08:55 -0500 Message-ID: <54737431.4070407@sonymobile.com> Date: Mon, 24 Nov 2014 10:08:49 -0800 From: Tim Bird User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Shuah Khan , "linux-api@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-embedded@vger.kernel.org" Subject: Re: [PATCH v2] selftest: size: Add size test for Linux kernel References: <546D084D.20002@sonymobile.com> <546D321F.2080405@sonymobile.com> <546E640F.1090006@osg.samsung.com> In-Reply-To: <546E640F.1090006@osg.samsung.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2014 01:58 PM, Shuah Khan wrote: > On 11/19/2014 05:13 PM, Tim Bird wrote: >> >> This test shows the amount of memory used by the system. >> Note that this is dependent on the user-space that is loaded >> when this program runs. Optimally, this program would be >> run as the init program itself. >> >> The program is optimized for size itself, to avoid conflating >> its own execution with that of the system software. >> The code is compiled statically, with no stdlibs. On my x86_64 system, >> this results in a statically linked binary of less than 5K. >> >> Changes from v1: >> - use more correct Copyright string in get_size.c >> >> Signed-off-by: Tim Bird >> --- >> tools/testing/selftests/Makefile | 1 + >> tools/testing/selftests/size/Makefile | 21 +++++++ >> tools/testing/selftests/size/get_size.c | 105 ++++++++++++++++++++++++++++++++ >> 3 files changed, 127 insertions(+) >> create mode 100644 tools/testing/selftests/size/Makefile >> create mode 100644 tools/testing/selftests/size/get_size.c > > Tim, > > The test looks good, but you are missing .gitignore file. > Please add a .gitignore for the binary that gets generated to > avoid git status including the binary it in its output. Will do. I'll send v3 today. Thanks, -- Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/