Date: Mon, 24 Nov 2014 19:48:31 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
        rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com
Subject: Re: [PATCH v3 00/41] linux: towards virtio-1 guest support
Message-ID: <20141124194831.252318e4.cornelia.huck@de.ibm.com>
In-Reply-To: <1416829787-14252-1-git-send-email-mst@redhat.com>
References: <1416829787-14252-1-git-send-email-mst@redhat.com>
Organization: IBM Deutschland Research & Development GmbH Vorsitzende des
 Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?=
 Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?=
 Registergericht: Amtsgericht Stuttgart, HRB 243294
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 24 Nov 2014 13:52:32 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Based on patches by Cornelia Rusty and others, but
> with an API that should allow better static checking of code,
> and slightly more concervative changes in vring,net and blk.
> 
> Based on patches by Cornelia and others, but
> with an API that should allow better static checking of code,
> slightly more concervative changes in vring and drivers,
> and compatibility for existing drivers so that
> this series be applied before all drivers are converted.
> 
> virtio net,blk and scsi drivers have been converted.
> They now pass sparse without warnings.
> 
> net and blk patches have been tested on s390.

vring_transport_features() seems to knock off the version 1 bit (I
wonder why I did not see that before, maybe VIRTIO_TRANSPORT_F_END had
not been increased before?). If I add VIRTIO_F_VERSION_1 in this
function, virtio-net and virtio-blk seem to work fine with version 1 on
virtio-ccw (tested with my old virtio-1 qemu branch).

I'll try to do a bit of reviewing tomorrow.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/