Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750935AbaKXUlF (ORCPT ); Mon, 24 Nov 2014 15:41:05 -0500 Received: from www.linutronix.de ([62.245.132.108]:41227 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbaKXUlD (ORCPT ); Mon, 24 Nov 2014 15:41:03 -0500 Date: Mon, 24 Nov 2014 21:41:00 +0100 (CET) From: Thomas Gleixner To: Daniel Thompson cc: Jason Cooper , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal , Dirk Behme , Daniel Drake , Dmitry Pervushin , Marc Zyngier Subject: Re: [PATCH 3.18-rc3 v8 1/4] irqchip: gic: Make gic_raise_softirq() FIQ-safe In-Reply-To: <547396D0.5030309@linaro.org> Message-ID: References: <1415183260-6389-1-git-send-email-daniel.thompson@linaro.org> <1415968543-29469-1-git-send-email-daniel.thompson@linaro.org> <1415968543-29469-2-git-send-email-daniel.thompson@linaro.org> <547396D0.5030309@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Nov 2014, Daniel Thompson wrote: > I did want to remove the lock too. However when I reviewed this code I > concluded the lock was still required. Without it I think it is possible > for gic_raise_softirq() to raise an IPI on the old core *after* the code > to migrate pending IPIs has been run. And I bet it took you quite some time to figure that out from that overly documented abuse of irq_controller_lock. See my other reply. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/