Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbaKXVtf (ORCPT ); Mon, 24 Nov 2014 16:49:35 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35753 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbaKXVtc (ORCPT ); Mon, 24 Nov 2014 16:49:32 -0500 Date: Mon, 24 Nov 2014 22:49:26 +0100 From: Pieter Smith To: Greg KH Cc: josh@joshtriplett.org, Richard Weinberger , "Michael S. Tsirkin" , Bertrand Jacquin , Oleg Nesterov , "J. Bruce Fields" , Eric Dumazet , =?utf-8?B?6JSh5q2j6b6Z?= , Jeff Layton , Tom Herbert , Alexei Starovoitov , Miklos Szeredi , Peter Foley , Hugh Dickins , Xiao Guangrong , Geert Uytterhoeven , Mel Gorman , Matt Turner , "Paul E. McKenney" , Alexander Duyck , "open list:FUSE: FILESYSTEM..." , "Luis R. Rodriguez" , Catalina Mocanu , Fabian Frederick , Thomas Graf , Paul Durrant , Alexander Viro , Jan Beulich , Willem de Bruijn , Iulia Manda , "open list:ABI/API" , open list , Daniel Borkmann , "Eric W. Biederman" , "open list:NETWORKING [GENERAL]" , linux-fsdevel , Andrew Morton , "David S. Miller" Subject: Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice Message-ID: <20141124214926.GA9371@smipidev> References: <1416752468-1626-1-git-send-email-pieter@boesman.nl> <1416752468-1626-5-git-send-email-pieter@boesman.nl> <20141123232302.GA12456@thin> <20141124094931.GA1055@smipidev> <20141124160510.GA2446@jtriplet-mobl1> <20141124193412.GB31618@kroah.com> <20141124201450.GA18776@cloud> <20141124202214.GA11362@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141124202214.GA11362@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 24, 2014 at 12:22:14PM -0800, Greg KH wrote: > On Mon, Nov 24, 2014 at 12:14:50PM -0800, josh@joshtriplett.org wrote: > > > I would, again, argue that stuff like __splice_p() not be implemented at > > > all please. It will only cause a huge proliferation of stuff like this > > > that will not make any sense, and only cause a trivial, if any, amount > > > of code savings. > > > > > > I thought you were going to not do this type of thing until you got the > > > gcc optimizer working for function callbacks. > > > > Compared to the previous patchset, there are now only two instances of > > ifdefs outside of the splice code for this, and this is one of them. In > > this case, the issue is no longer about making the code for this > > splice_read function disappear, but rather to eliminate a reference to a > > bit of splice functionality (used *inside* the FUSE splice code) that > > will not work without SPLICE_SYSCALL. > > > > Would you prefer to see this specific case handled via an #ifdef in > > fs/fuse/dev.c rather than introducing a __splice_p that people might be > > inclined to propagate? That'd be fine; the code could simply wrap > > fuse_dev_splice_read in an #ifdef and have the #else define a NULL > > fuse_dev_splice_read. > > Yes, I would prefer that, but I'm not the fuse maintainer. > > thanks, > > greg k-h Okay. I'll do my part to prevent the type of proliferation guaranteed to rate high on the respected K-H icky-scale. __splice_p() goes the way of the dodo in favor of the solution presented by Josh. I pray that the Gods of fuse maintenance will look favorable upon the result. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/