Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750927AbaKYAJT (ORCPT ); Mon, 24 Nov 2014 19:09:19 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:43247 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbaKYAJR convert rfc822-to-8bit (ORCPT ); Mon, 24 Nov 2014 19:09:17 -0500 Content-Type: text/plain; charset=koi8-r Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v3 2/4] i2c: omap: implement workaround for handling invalid BB-bit values From: Alexander Kochetkov In-Reply-To: <47749B61-5924-4E56-9931-77B0CFC0AAA0@gmail.com> Date: Tue, 25 Nov 2014 03:09:13 +0300 Cc: Kevin Hilman , Felipe Balbi , Wolfram Sang , linux-omap , linux-i2c@vger.kernel.org, lkml Content-Transfer-Encoding: 8BIT Message-Id: <06376010-5DED-49AA-9494-A9546567E7CA@gmail.com> References: <1416518925-20679-1-git-send-email-al.kochet@gmail.com> <1416685634-5864-1-git-send-email-al.kochet@gmail.com> <1416685634-5864-3-git-send-email-al.kochet@gmail.com> <47A1A441-952C-4AC3-859C-5A8E405767E0@gmail.com> <20141124194759.GG2757@atomide.com> <47749B61-5924-4E56-9931-77B0CFC0AAA0@gmail.com> To: Tony Lindgren X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 24 ????. 2014 ?., ? 23:05, Alexander Kochetkov ???????(?): > Something (u-boot, may be) leave the bus in the wrong state. > Really strange. Actually something wrong with i2c-pullups on i2c.1 bus on fault boards. May be these are boards without pull-ups? All beagles doesn't have internal pull-ups on i2c.1 since u-boot 2011.x. Here is the bug in the u-boot related to beagle: http://git.denx.de/?p=u-boot.git;a=commit;h=04e2a13336f0e507ef416bbede3be92b79c46594 Yes, I made fix, but keep that in mind. For example one of the boards (omap3-beagle): http://status.armcloud.us/boot/omap3-beagle/job/next/kernel/next-20141124/defconfig/arm-omap2plus_defconfig/ http://status.armcloud.us/boot/omap3-beagle,legacy/job/next/kernel/next-20141124/defconfig/arm-omap2plus_defconfig/ http://status.armcloud.us/boot/omap3-beagle/job/next/kernel/next-20141124/defconfig/arm-multi_v7_defconfig/ has following warning message in the u-boot log: > U-Boot 2014.07 (Aug 21 2014 - 11:03:05) > > OMAP3530-GP ES3.0, CPU-OPP2, L3-165MHz, Max CPU Clock 600 MHz > OMAP3 Beagle board + LPDDR/NAND > .... > Beagle Rev C1/C2/C3 > Timed out in wait_for_event: status=1000 > Check if pads/pull-ups of bus 1 are properly configured Also beagle schematic has following log entry for A3: 4. Added optional pullup resistors on I2C2_SCL and I2C_SDA into the layout. Is the fault beagle is pre A3 revision? I can't tell anything about second one board (omap3-overo-tobi), because I could not get it schematic. And how you have i2c.1 working without pull-ups I don't know. Alexander. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/