Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbaKYA47 (ORCPT ); Mon, 24 Nov 2014 19:56:59 -0500 Received: from mail-ob0-f178.google.com ([209.85.214.178]:39075 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbaKYA44 (ORCPT ); Mon, 24 Nov 2014 19:56:56 -0500 MIME-Version: 1.0 In-Reply-To: <1416820395.19925.4.camel@linux-0dmf.site> References: <1415909806-23848-1-git-send-email-bleung@chromium.org> <1415956110.2640.5.camel@linux-0dmf.site> <1416820395.19925.4.camel@linux-0dmf.site> Date: Mon, 24 Nov 2014 16:56:56 -0800 X-Google-Sender-Auth: k76Pyu4Vbnd45FE-Mut6rk_NOK4 Message-ID: Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup From: Benson Leung To: Oliver Neukum Cc: johan@kernel.org, Jiri Kosina , linux-usb@vger.kernel.org, "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oliver, On Mon, Nov 24, 2014 at 1:13 AM, Oliver Neukum wrote: > > But there is very little to be gained by switching off remote wakeup. > The additional energy consumption devices with remote wakeup enabled > will be dwarfed by the energy needed for an additional wakeup. > That makes sense to me. Does this mean we should be moving toward a solution that doesn't wake suspended devices on close for other usb devices, not just hid? This particular pattern of get()/needs_remote_wakeup=0/put() on close() appears in several other drivers, for example : 62ecae0 Input: wacom - properly enable runtime PM 5d9efc5 Input: usbtouchscreen - implement runtime power management -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/