Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbaKYI6D (ORCPT ); Tue, 25 Nov 2014 03:58:03 -0500 Received: from mail-yh0-f49.google.com ([209.85.213.49]:39265 "EHLO mail-yh0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbaKYI6A (ORCPT ); Tue, 25 Nov 2014 03:58:00 -0500 MIME-Version: 1.0 In-Reply-To: References: <1416833572-6880-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> Date: Tue, 25 Nov 2014 14:27:58 +0530 X-Google-Sender-Auth: E-Izyh2KaM7YRsnHL5PTZ4kWGro Message-ID: Subject: Re: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain From: amit daniel kachhap To: Ulf Hansson Cc: "devicetree@vger.kernel.org" , Kukjin Kim , Kevin Hilman , Pankaj Dubey , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Geert Uytterhoeven , Sylwester Nawrocki , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 25, 2014 at 1:29 PM, Ulf Hansson wrote: > On 24 November 2014 at 14:04, Amit Daniel Kachhap > wrote: >> This patch adds supports for parent power domain. This will ensure >> invoking of parent/child power domain on/off in a correct sequence. >> In exynos7 SOC's, power domain controllers have parent and child >> hierarchy. >> >> Cc: Kukjin Kim >> Signed-off-by: Amit Daniel Kachhap >> --- >> .../bindings/arm/exynos/power_domain.txt | 2 + >> drivers/soc/samsung/pm_domains.c | 43 +++++++++++++++++++- >> 2 files changed, 44 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >> index 00ebda1..0160bdc 100644 >> --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >> +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt >> @@ -24,6 +24,7 @@ Optional Properties: >> - pclkN, clkN: Pairs of parent of input clock and input clock to the >> devices in this power domain. Maximum of 4 pairs (N = 0 to 3) >> are supported currently. >> +- parents: phandle of parent power domains. >> >> Node of a device using power domains must have a samsung,power-domain property >> defined with a phandle to respective power domain. >> @@ -48,6 +49,7 @@ Example: >> mfc_pd: power-domain@10044060 { >> compatible = "samsung,exynos4210-pd", "samsung,exynos7-pd-mfc"; >> reg = <0x10044060 0x20>; >> + parents = <&pd_top>; >> #power-domain-cells = <0>; >> }; > > This seems like a good and generic approach to describe that a PM > domain could have a parent. I would suggest to rename it, such it > reflects its a PM domain binding though. I am not sure if this is generic. I guess PD's represented like below are more generic. PD1 { PD2 { PD3 { }; }; }; > > So, maybe we can add this as a common DT binding for the generic PM > domain instead of having it as Exynos specific? Yes sure. Regards, Amit D > > Kind regards > Uffe > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/