Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbaKYKJB (ORCPT ); Tue, 25 Nov 2014 05:09:01 -0500 Received: from gloria.sntech.de ([95.129.55.99]:33592 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbaKYKI7 (ORCPT ); Tue, 25 Nov 2014 05:08:59 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Kever Yang Cc: Roger Chen , peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, eddie.cai@rock-chips.com Subject: Re: [PATCH 3/4] GMAC: dts: add gmac info for rk3288 Date: Tue, 25 Nov 2014 11:12:44 +0100 Message-ID: <1964829.jls4nocKCY@diego> User-Agent: KMail/4.14.1 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <54745229.2040503@rock-chips.com> References: <1416906536-26158-1-git-send-email-roger.chen@rock-chips.com> <54745229.2040503@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, Kever, Am Dienstag, 25. November 2014, 17:55:53 schrieb Kever Yang: > The Subject should use below prefix: > ARM: dts: rockchip: add gmac info for rk3288 > > On 11/25/2014 05:08 PM, Roger Chen wrote: > > add gmac info in rk3288.dtsi for GMAC driver > > > > Signed-off-by: Roger Chen > > --- > > > > arch/arm/boot/dts/rk3288.dtsi | 59 > > +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 > > insertions(+) > > > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > > index 0f50d5d..949675d 100644 > > --- a/arch/arm/boot/dts/rk3288.dtsi > > +++ b/arch/arm/boot/dts/rk3288.dtsi > > @@ -137,6 +137,13 @@ > > > > #clock-cells = <0>; > > > > }; > > > > + ext_gmac: external-gmac-clock { > > + compatible = "fixed-clock"; > > + clock-frequency = <125000000>; > > + clock-output-names = "ext_gmac"; > > + #clock-cells = <0>; > > + }; > > + > > I'm not sure Heiko will happy with both add the new clock source and > gmac node in these patch. correct. The ext_gmac is an external clock input providing a special clock to the gmac. This makes it a board-specific property, which should also only be added on boards having this external source - and of course in the board- specific dts. > > > timer { > > > > compatible = "arm,armv7-timer"; > > interrupts = > IRQ_TYPE_LEVEL_HIGH)>, > > > > @@ -490,6 +497,25 @@ > > > > reg = <0xff740000 0x1000>; > > > > }; > > > > + gmac: eth@ff290000 { > > + compatible = "rockchip,rk3288-gmac"; > > + reg = <0xff290000 0x10000>; > > + interrupts = ; /*irq=59*/ please remote the "irq=59" comment, as it is not necessary > > + interrupt-names = "macirq"; > > + rockchip,grf = <&grf>; > > + clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_PLL>, > > + <&cru SCLK_MAC_RX>, <&cru SCLK_MAC_TX>, > > + <&cru SCLK_MACREF>, <&cru SCLK_MACREF_OUT>, > > + <&cru ACLK_GMAC>, <&cru PCLK_GMAC>; > > + clock-names = "stmmaceth", "clk_mac_pll", > > + "mac_clk_rx", "mac_clk_tx", > > + "clk_mac_ref", "clk_mac_refout", > > + "aclk_mac", "pclk_mac"; > > + phy-mode = "rgmii"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&rgmii_pin /*&rmii_pin*/>; > > + }; > > + > > The controller dts node should be sort by the base address, I'm sure > this is in a > wrong place. correct, it is on the wrong place Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/