Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S266354AbSLVMGY>; Sun, 22 Dec 2002 07:06:24 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S266356AbSLVMGY>; Sun, 22 Dec 2002 07:06:24 -0500
Received: from twilight.ucw.cz ([195.39.74.230]:20101 "EHLO twilight.ucw.cz")
	by vger.kernel.org with ESMTP id <S266354AbSLVMGW>;
	Sun, 22 Dec 2002 07:06:22 -0500
Date: Sun, 22 Dec 2002 13:14:22 +0100
From: Vojtech Pavlik <vojtech@suse.cz>
To: mdew <mdew@orcon.net.nz>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
       "torvalds@transmeta.com" <torvalds@transmeta.com>,
       Vojtech Pavlik <vojtech@suse.cz>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH 2.5] [TRIVIAL] USB Joypad quirk
Message-ID: <20021222131422.A507@ucw.cz>
References: <1040556042.9822.17.camel@nirvana>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <1040556042.9822.17.camel@nirvana>; from mdew@orcon.net.nz on Mon, Dec 23, 2002 at 12:20:30AM +1300
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2576
Lines: 77

On Mon, Dec 23, 2002 at 12:20:30AM +1300, mdew wrote:
> Orginally from Vojtech Pavlik (16th June 2002 via email), to fix my
> 'broken' USB joypad, Fully tested in both 2.4.x and 2.5.52 (and
> 2.5.52-bk).

Yes, Greg, this can go in.

> 
> -mdew
> 
> 
> 
> diff -Naur a/drivers/usb/input/hid-core.c
> mdew/drivers/usb/input/hid-core.c
> --- a/drivers/usb/input/hid-core.c	2002-11-28 11:36:04.000000000 +1300
> +++ mdew/drivers/usb/input/hid-core.c	2002-12-22 23:37:51.000000000
> +1300
> @@ -1317,6 +1317,9 @@
>  #define USB_DEVICE_ID_ATEN_2PORTKVM    0x2204
>  #define USB_DEVICE_ID_ATEN_4PORTKVM    0x2205
>  
> +#define USB_VENDOR_ID_TOPMAX           0x0663
> +#define USB_DEVICE_ID_TOPMAX_COBRAPAD  0x0103
> +
>  #define USB_VENDOR_ID_MGE              0x0463
>  #define USB_DEVICE_ID_MGE_UPS          0xffff
>  #define USB_DEVICE_ID_MGE_UPS1         0x0001
> @@ -1355,6 +1358,7 @@
>  	{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVM, HID_QUIRK_NOGET },
>  	{ USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_HIDDEV },
>  	{ USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS1, HID_QUIRK_HIDDEV },
> +	{ USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD,
> HID_QUIRK_BADPAD },
>  	{ 0, 0 }
>  };
>  
> diff -Naur a/drivers/usb/input/hid-input.c
> mdew/drivers/usb/input/hid-input.c
> --- a/drivers/usb/input/hid-input.c	2002-11-28 11:35:59.000000000 +1300
> +++ mdew/drivers/usb/input/hid-input.c	2002-12-22 23:41:25.000000000
> +1300
> @@ -357,6 +357,11 @@
>  		int a = field->logical_minimum;
>  		int b = field->logical_maximum;
>  
> +		if ((device->quirks & HID_QUIRK_BADPAD) && (usage->code == ABS_X ||
> usage->code == ABS_Y)) {
> +			a = field->logical_minimum = 0;
> +			b = field->logical_maximum = 255;
> +		}
> +		
>  		input->absmin[usage->code] = a;
>  		input->absmax[usage->code] = b;
>  		input->absfuzz[usage->code] = (b - a) >> 8;
> diff -Naur a/drivers/usb/input/hid.h mdew/drivers/usb/input/hid.h
> --- a/drivers/usb/input/hid.h	2002-11-28 11:35:46.000000000 +1300
> +++ mdew/drivers/usb/input/hid.h	2002-12-22 23:38:49.000000000 +1300
> @@ -206,6 +206,7 @@
>  #define HID_QUIRK_IGNORE	0x04
>  #define HID_QUIRK_NOGET		0x08
>  #define HID_QUIRK_HIDDEV	0x10
> +#define HID_QUIRK_BADPAD        0x12
>  
>  /*
>   * This is the global enviroment of the parser. This information is
> 



-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/