Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbaKYNlF (ORCPT ); Tue, 25 Nov 2014 08:41:05 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:48099 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbaKYNlD (ORCPT ); Tue, 25 Nov 2014 08:41:03 -0500 Message-ID: <547486EB.5080702@cogentembedded.com> Date: Tue, 25 Nov 2014 16:40:59 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Roger Chen , heiko@sntech.de CC: peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kever.yang@rock-chips.com, mark.yao@rock-chips.com, eddie.cai@rock-chips.com Subject: Re: [PATCH 3/4] GMAC: dts: add gmac info for rk3288 References: <1416906536-26158-1-git-send-email-roger.chen@rock-chips.com> In-Reply-To: <1416906536-26158-1-git-send-email-roger.chen@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 11/25/2014 12:08 PM, Roger Chen wrote: > add gmac info in rk3288.dtsi for GMAC driver > Signed-off-by: Roger Chen > --- > arch/arm/boot/dts/rk3288.dtsi | 59 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 0f50d5d..949675d 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi [...] > @@ -490,6 +497,25 @@ > reg = <0xff740000 0x1000>; > }; > > + gmac: eth@ff290000 { Please name the node "ethernet@ff290000" to comply with the ePAPR standard. > + compatible = "rockchip,rk3288-gmac"; > + reg = <0xff290000 0x10000>; > + interrupts = ; /*irq=59*/ > + interrupt-names = "macirq"; > + rockchip,grf = <&grf>; > + clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_PLL>, > + <&cru SCLK_MAC_RX>, <&cru SCLK_MAC_TX>, > + <&cru SCLK_MACREF>, <&cru SCLK_MACREF_OUT>, > + <&cru ACLK_GMAC>, <&cru PCLK_GMAC>; > + clock-names = "stmmaceth", "clk_mac_pll", > + "mac_clk_rx", "mac_clk_tx", > + "clk_mac_ref", "clk_mac_refout", > + "aclk_mac", "pclk_mac"; > + phy-mode = "rgmii"; > + pinctrl-names = "default"; > + pinctrl-0 = <&rgmii_pin /*&rmii_pin*/>; Hm, pinctrl props in a .dtsi file? Those are usually board dependent. [...] > @@ -1040,5 +1066,38 @@ > rockchip,pins = <7 23 3 &pcfg_pull_none>; > }; > }; > + > + gmac { > + rgmii_pin: rgmii-pins { > + rockchip,pins = <3 30 3 &pcfg_pull_none>, > + <3 31 3 &pcfg_pull_none>, > + <3 26 3 &pcfg_pull_none>, > + <3 27 3 &pcfg_pull_none>, > + <3 28 3 &pcfg_pull_none>, > + <3 29 3 &pcfg_pull_none>, > + <3 24 3 &pcfg_pull_none>, > + <3 25 3 &pcfg_pull_none>, > + <4 0 3 &pcfg_pull_none>, > + <4 5 3 &pcfg_pull_none>, > + <4 6 3 &pcfg_pull_none>, > + <4 9 3 &pcfg_pull_none>, > + <4 4 3 &pcfg_pull_none>, > + <4 1 3 &pcfg_pull_none>, > + <4 3 3 &pcfg_pull_none>; > + }; > + > + rmii_pin: rmii-pins { > + rockchip,pins = <3 30 3 &pcfg_pull_none>, > + <3 31 3 &pcfg_pull_none>, > + <3 28 3 &pcfg_pull_none>, > + <3 29 3 &pcfg_pull_none>, > + <4 0 3 &pcfg_pull_none>, > + <4 5 3 &pcfg_pull_none>, > + <4 4 3 &pcfg_pull_none>, > + <4 1 3 &pcfg_pull_none>, > + <4 2 3 &pcfg_pull_none>, > + <4 3 3 &pcfg_pull_none>; > + }; > + }; These are usually define in the board .dts file... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/