Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbaKZJTF (ORCPT ); Wed, 26 Nov 2014 04:19:05 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:47574 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbaKZJTA (ORCPT ); Wed, 26 Nov 2014 04:19:00 -0500 Date: Wed, 26 Nov 2014 10:18:47 +0100 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, Rusty Russell , virtualization@lists.linux-foundation.org, linux-api@vger.kernel.org Subject: Re: [PATCH v4 09/42] virtio: set FEATURES_OK Message-ID: <20141126101847.615daac4.cornelia.huck@de.ibm.com> In-Reply-To: <20141125213823.GC22343@redhat.com> References: <1416933600-21398-1-git-send-email-mst@redhat.com> <1416933600-21398-10-git-send-email-mst@redhat.com> <20141125184811.3191f8db.cornelia.huck@de.ibm.com> <20141125213823.GC22343@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112609-0041-0000-0000-000002421292 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Nov 2014 23:38:23 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 25, 2014 at 06:48:11PM +0100, Cornelia Huck wrote: > > On Tue, 25 Nov 2014 18:42:01 +0200 > > "Michael S. Tsirkin" wrote: > > > > > set FEATURES_OK as per virtio 1.0 spec > > > > > > Signed-off-by: Michael S. Tsirkin > > > --- > > > include/uapi/linux/virtio_config.h | 2 ++ > > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > > > 2 files changed, 24 insertions(+), 7 deletions(-) > > > > > > > > + if (virtio_has_feature(dev, VIRTIO_F_VERSION_1)) { > > > + add_status(dev, VIRTIO_CONFIG_S_FEATURES_OK); > > > + status = dev->config->get_status(dev); > > > + if (!(status & VIRTIO_CONFIG_S_FEATURES_OK)) { > > > + printk(KERN_ERR "virtio: device refuses features: %x\n", > > > + status); > > > > Can you use dev_err() to include the information which device failed? > > I'm not sure - is dev_err OK to use from probe? The dev_* functions should be fine anytime, but the driver has already been set before ->probe is called anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/