Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbaKZJxo (ORCPT ); Wed, 26 Nov 2014 04:53:44 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:41263 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbaKZJxl (ORCPT ); Wed, 26 Nov 2014 04:53:41 -0500 Date: Wed, 26 Nov 2014 10:53:32 +0100 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, Rusty Russell , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 19/42] virtio_blk: fix race at module removal Message-ID: <20141126105332.6ea70c08.cornelia.huck@de.ibm.com> In-Reply-To: <1416933600-21398-20-git-send-email-mst@redhat.com> References: <1416933600-21398-1-git-send-email-mst@redhat.com> <1416933600-21398-20-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112609-0025-0000-0000-000002986F28 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Nov 2014 18:42:46 +0200 "Michael S. Tsirkin" wrote: > If a device appears while module is being removed, > driver will get a callback after we've given up > on the major number. > > In theory this means this major number can get reused > by something else, resulting in a conflict. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Cornelia Huck This and the previous patch are independent of virtio 1.0, aren't they? Maybe you should put them at the top of your queue :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/