Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbaKZKbs (ORCPT ); Wed, 26 Nov 2014 05:31:48 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35990 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbaKZKbp (ORCPT ); Wed, 26 Nov 2014 05:31:45 -0500 Date: Wed, 26 Nov 2014 11:31:43 +0100 Message-ID: From: Takashi Iwai To: Oliver Neukum Cc: Marcel Holtmann , Dave Jones , Linux Kernel , pgynther@google.com, linux-bluetooth@vger.kernel.org Subject: Re: bluetooth related firmware loader spew on resume. In-Reply-To: <1416996623.3171.7.camel@linux-0dmf.site> References: <20141111181228.GA27815@redhat.com> <1416996623.3171.7.camel@linux-0dmf.site> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 26 Nov 2014 11:10:23 +0100, Oliver Neukum wrote: > > On Wed, 2014-11-26 at 09:52 +0100, Takashi Iwai wrote: > > At Wed, 26 Nov 2014 14:15:27 +0900, > > > In order to paper over this, we may also remember the failing firmware > > and avoid loading it. This might be an easer way than the endless > > fight against UMH race... > > Hi, > > the full fix would be to implement reset_resume() for btusb. > It seems to me that setup() should be split in two methods, > one to request the firmware from user space and the second > to transfer it to the device. reset_resume() would just need > to repeat the second operation. I'm not against it, but one slight drawback is that you'll have to remember the firmware content to transfer by the driver itself in this scenario. In the firmware loader framework, the content is re-read at resume so that the largish content isn't kept unnecessarily during the whole operation. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/