Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbaKZLg1 (ORCPT ); Wed, 26 Nov 2014 06:36:27 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:39609 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbaKZLg0 (ORCPT ); Wed, 26 Nov 2014 06:36:26 -0500 Message-ID: <5475BB30.9080802@arm.com> Date: Wed, 26 Nov 2014 11:36:16 +0000 From: Marc Zyngier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Liviu Dudau CC: "arm@kernel.org" , Olof Johansson , Arnd Bergmann , Kevin Hilman , Mark Rutland , device tree , Pawel Moll , Ian Campbell , Catalin Marinas , Will Deacon , LKML , Rob Herring , Kumar Gala , LAKML Subject: Re: [PATCH v3 2/2] arm64: Add Juno board device tree. References: <1415727131-4572-1-git-send-email-Liviu.Dudau@arm.com> <1415727131-4572-3-git-send-email-Liviu.Dudau@arm.com> <5475ABC0.3090007@arm.com> <20141126105918.GB828@e106497-lin.cambridge.arm.com> In-Reply-To: <20141126105918.GB828@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/14 10:59, Liviu Dudau wrote: > On Wed, Nov 26, 2014 at 10:30:24AM +0000, Marc Zyngier wrote: >> Hi Liviu, >> >> On 11/11/14 17:32, Liviu Dudau wrote: >>> This adds support for ARM's Juno development board (rev 0). >>> It enables most of the board peripherals: UART, I2C, USB, MMC and >>> 100Mb ethernet. There is no support at the moment for clock setting >>> and HDLCD driver which depends on it. >>> >>> Signed-off-by: Liviu Dudau >>> --- >>> arch/arm64/boot/dts/arm/Makefile | 1 + >>> arch/arm64/boot/dts/arm/juno-clocks.dtsi | 45 ++++++ >>> arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 129 +++++++++++++++ >>> arch/arm64/boot/dts/arm/juno.dts | 218 ++++++++++++++++++++++++++ >>> 4 files changed, 393 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/arm/juno-clocks.dtsi >>> create mode 100644 arch/arm64/boot/dts/arm/juno-motherboard.dtsi >>> create mode 100644 arch/arm64/boot/dts/arm/juno.dts >>> >> >> [...] >> >>> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts >>> new file mode 100644 >>> index 0000000..097ecc4 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/arm/juno.dts >> >> [...] >> >>> + timer { >>> + compatible = "arm,armv8-timer"; >>> + interrupts = , >>> + , >>> + , >>> + ; >>> + }; >> >> Sorry, I should have spotted this earlier: all these interrupts are >> *level*, not edge. This happens to work because the GIC's config >> register is RO for PPIs on Juno, but still... > > Yes, I've seen your other email to Suravee regarding interrupt triggering and I was trying to > find the relevant bits in Juno to tell me why I've put the info in DT this way. Maybe I *did* > copy-paste this part from FVP DT though. > > I will send a patch to Olof to update. Yeah, looks like most (if not all) DTs in the tree are broken. Any chance you could write a sweeping patch to fix them all (at least for the ARM implementations)? The APM and Cavium implementations also carry the same values, and I suppose this is a bug too, but someone with access to documentation should figure this out. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/