Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbaKZMkt (ORCPT ); Wed, 26 Nov 2014 07:40:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42798 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbaKZMks (ORCPT ); Wed, 26 Nov 2014 07:40:48 -0500 Date: Wed, 26 Nov 2014 13:40:26 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Steven Rostedt Cc: Jan Kiszka , Paolo Bonzini , nick , gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Another Obsolete Fix me in trace.h? Message-ID: <20141126124022.GC6795@potion.brq.redhat.com> References: <5472B5B5.5090201@gmail.com> <54730475.9040000@redhat.com> <54730B33.1080101@siemens.com> <20141124210000.GB6795@potion.brq.redhat.com> <20141124161901.6266925c@gandalf.local.home> <20141124214939.GA6671@potion.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141124214939.GA6671@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-11-24 22:49+0100, Radim Krčmář: > 2014-11-24 16:19-0500, Steven Rostedt: > > That wouldn't be too hard to implement. > > I'll look at the patch tommorrow. The kernel part is trivial. Most of the code is going to be in tools/lib/traceevent/event-parse.c. I wasn't sure whether to 1) define new 'enum print_arg_type' for our function and do exactly what other __print* did 2) extend existing PRINT_FUNC with variable arguments and register it as a "global" event handler as (2) makes more sense to me, but we already had it when some __print* was implemented ... (and I didn't want to dig too deep into the project) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/