Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbaKZNJJ (ORCPT ); Wed, 26 Nov 2014 08:09:09 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:52676 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbaKZNJG (ORCPT ); Wed, 26 Nov 2014 08:09:06 -0500 Date: Wed, 26 Nov 2014 14:08:57 +0100 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, Rusty Russell , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH v4 24/42] virtio_net: enable v1.0 support Message-ID: <20141126140857.6ff85e4b.cornelia.huck@de.ibm.com> In-Reply-To: <1416933600-21398-25-git-send-email-mst@redhat.com> References: <1416933600-21398-1-git-send-email-mst@redhat.com> <1416933600-21398-25-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112613-0021-0000-0000-000001EBC7FB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Nov 2014 18:43:06 +0200 "Michael S. Tsirkin" wrote: > Now that we have completed 1.0 support, enable it in our driver. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > Hm. The spec states that mac is driver-writable in the legacy case. Don't we need to fence writing it in virtnet_set_mac_address() in the virtio 1.0 case? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/