Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982AbaK0FuP (ORCPT ); Thu, 27 Nov 2014 00:50:15 -0500 Received: from mail4.hitachi.co.jp ([133.145.228.5]:49158 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbaK0FuN (ORCPT ); Thu, 27 Nov 2014 00:50:13 -0500 Message-ID: <5476BB87.6010808@hitachi.com> Date: Thu, 27 Nov 2014 14:49:59 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Shuah Khan Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, mmarek@suse.cz, davem@davemloft.net, keescook@chromium.org, tranmanphong@gmail.com, dh.herrmann@gmail.com, hughd@google.com, bobby.prani@gmail.com, ebiederm@xmission.com, serge.hallyn@ubuntu.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, "yrl.pp-manager.tt@hitachi.com" Subject: Re: [PATCH v2 11/19] selftests/memory-hotplug: add install target to enable installing test References: <8cdb2abb6eaa794801548e04ee6b9f403778e126.1415735831.git.shuahkh@osg.samsung.com> In-Reply-To: <8cdb2abb6eaa794801548e04ee6b9f403778e126.1415735831.git.shuahkh@osg.samsung.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/11/12 5:27), Shuah Khan wrote: > Add a new make target to enable installing test. This target > installs test in the kselftest install location and add to the > kselftest script to run the test. Install target can be run > only from top level source dir. > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/memory-hotplug/Makefile | 17 +- > .../selftests/memory-hotplug/mem-on-off-test.sh | 238 +++++++++++++++++++++ > .../selftests/memory-hotplug/on-off-test.sh | 238 --------------------- > 3 files changed, 253 insertions(+), 240 deletions(-) > create mode 100644 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > delete mode 100644 tools/testing/selftests/memory-hotplug/on-off-test.sh > > diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile > index d46b8d4..8921631 100644 > --- a/tools/testing/selftests/memory-hotplug/Makefile > +++ b/tools/testing/selftests/memory-hotplug/Makefile > @@ -1,9 +1,22 @@ > +TEST_STR=/bin/bash ./mem-on-off-test.sh -r 2 || echo memory-hotplug selftests: [FAIL] > + > all: > > +install: > +ifdef INSTALL_KSFT_PATH > + install ./mem-on-off-test.sh $(INSTALL_KSFT_PATH)/mem-on-off-test.sh > + @echo echo Start memory hotplug test .... >> $(KSELFTEST) > + @echo "$(TEST_STR)" >> $(KSELFTEST) >> $(KSELFTEST) > + @echo echo End memory hotplug test .... >> $(KSELFTEST) > + @echo echo ============================== >> $(KSELFTEST) > +else > + @echo Run make kselftest_install in top level source directory > +endif I saw this pattern repeated many times in this series. Can we make it a macro and include it instead of repeating this code? Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/