Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754198AbaK0K0n (ORCPT ); Thu, 27 Nov 2014 05:26:43 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:40405 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbaK0K0k (ORCPT ); Thu, 27 Nov 2014 05:26:40 -0500 Message-ID: <5476FC55.1020606@arm.com> Date: Thu, 27 Nov 2014 10:26:29 +0000 From: Marc Zyngier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Chanwoo Choi , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Mark Rutland , "jh80.chung@samsung.com" , "geunsik.lim@samsung.com" , "kgene.kim@samsung.com" , "arnd@arndb.de" , Catalin Marinas , "linus.walleij@linaro.org" , Will Deacon , "tomasz.figa@gmail.com" , "a.kesavan@samsung.com" , "inki.dae@samsung.com" , "sw0312.kim@samsung.com" , "kyungmin.park@samsung.com" , "thomas.abraham@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "s.nawrocki@samsung.com" , "olof@lixom.net" , "chanho61.park@samsung.com" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 16/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC References: <1417073716-22997-1-git-send-email-cw00.choi@samsung.com> <1417073716-22997-17-git-send-email-cw00.choi@samsung.com> In-Reply-To: <1417073716-22997-17-git-send-email-cw00.choi@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/14 07:35, Chanwoo Choi wrote: > This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC > based on Octal core CPUs (quad Cortex-A57 and quad Cortex-A53). > > Cc: Kukjin Kim > Cc: Mark Rutland > Cc: Arnd Bergmann > Cc: Olof Johansson > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Chanwoo Choi > Acked-by: Inki Dae > Acked-by: Geunsik Lim > --- > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 698 +++++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 523 +++++++++++++++ > 2 files changed, 1221 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > create mode 100644 arch/arm64/boot/dts/exynos/exynos5433.dtsi > [...] > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > new file mode 100644 > index 0000000..3d8b576 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi [...] > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <1 13 0xff01>, > + <1 14 0xff01>, > + <1 11 0xff01>, > + <1 10 0xff01>; This is wrong. Timer interrupts for both A53 and A57 are level triggered. > + clock-frequency = <24000000>; Please go and fix your firmware. Really... > + use-clocksource-only; > + use-physical-timer; > + }; Well, that's a total NAK. Neither of these properties are part of the binding, and we've already established that none of that would never be valid on arm64. I suggest you finally do what we've been asking for years, which is to fix your boot ROM by adding the 5 lines of assembly code that are needed instead of repeatedly post the same bogus DT files. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/