Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbaK0Opl (ORCPT ); Thu, 27 Nov 2014 09:45:41 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:40757 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbaK0Opk (ORCPT ); Thu, 27 Nov 2014 09:45:40 -0500 Message-ID: <54773906.5030504@arm.com> Date: Thu, 27 Nov 2014 14:45:26 +0000 From: Marc Zyngier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Liviu Dudau , "suravee.suthikulpanit@amd.com" CC: "arnd@arndb.de" , Mark Rutland , Will Deacon , Catalin Marinas , "robherring2@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "Lendacky, Thomas" , "Schopp, Joel" Subject: Re: [PATCH V4] arm64: amd-seattle: Adding device tree for AMD Seattle platform References: <547458B9.2000805@arm.com> <20141127142811.GN828@e106497-lin.cambridge.arm.com> In-Reply-To: <20141127142811.GN828@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/14 14:28, Liviu Dudau wrote: > On Tue, Nov 25, 2014 at 11:46:50AM +0000, Suthikulpanit, Suravee wrote: >> Hi Marc, >> >> On 11/25/14, 17:23, "Marc Zyngier" wrote: >> >>> Hi Suravee, >>> >>> Just spotted a small issue below (looks like a recurring mistake in a >>> number of DTs I've seem lately): >>> >>> On 24/11/14 21:51, suravee.suthikulpanit@amd.com wrote: >>>> From: Suravee Suthikulpanit >>>> >>>> Initial revision of device tree for AMD Seattle platform. >>>> >>>> Cc: Arnd Bergmann >>>> Cc: Marc Zyngier >>>> Cc: Mark Rutland >>>> Cc: Will Deacon >>>> Cc: Catalin Marinas >>>> Signed-off-by: Suravee Suthikulpanit >>>> Signed-off-by: Thomas Lendacky >>>> Signed-off-by: Joel Schopp >>>> --- >>>> V4 Changes: >>>> * Remove unnecessary smb layer and move motherbord to top level >>>> * Move include dtsi to top level >>>> * Remove apb_pclk from sata0 and i2c >>>> * Fix GIC Virtual Maintanance Interrupt from PPI24 (8) to PPI25 (9) >>>> * Add 40-bit dma-ranges for motherboard (simple-bus) >>>> * Remove dma0 (pl330) entry for now since it only supports 32-bit >>>> DMA. >>>> It is basically not used at the moment. It would also need SMMU >>>> to allow dma remapping to 40-bit DMA range. >>>> * Add phandle spi0 and spi1 >>>> * Hook up gpio0 pin 7 with MMC Card Detection (CD) support. >>>> * Changes in pcie0 entry: >>>> - Add 40-bit dma-ranges >>>> - Remove interrupts property >>>> - Add interrupt-map/mask property >>>> - Fix PCI I/O range >>>> - Merge PCI 32-bit ranges >>>> - Merge PCI 64-bit ranges >>>> >>>> NOTE: I am not add a new compatible ID for the sata0 as Rob Herring >>>> suggested since there is no need at the momement, and I am trying >>>> to avoid introducing ID unnecessarily. >>>> >>>> arch/arm64/Kconfig | 5 + >>>> arch/arm64/boot/dts/Makefile | 1 + >>>> arch/arm64/boot/dts/amd-seattle-periph.dtsi | 156 >>>> ++++++++++++++++++++++++++++ >>>> arch/arm64/boot/dts/amd-seattle.dts | 89 ++++++++++++++++ >>>> 4 files changed, 251 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/amd-seattle-periph.dtsi >>>> create mode 100644 arch/arm64/boot/dts/amd-seattle.dts >>>> >>> >>> [...] >>> >>>> diff --git a/arch/arm64/boot/dts/amd-seattle.dts >>>> b/arch/arm64/boot/dts/amd-seattle.dts >>>> new file mode 100644 >>>> index 0000000..d5fc482 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/amd-seattle.dts >>>> @@ -0,0 +1,89 @@ >>>> +/* >>>> + * DTS file for AMD Seattle >>>> + * >>>> + * Copyright (C) 2014 Advanced Micro Devices, Inc. >>>> + */ >>>> + >>>> +/dts-v1/; >>>> + >> >> [...] >> >>>> + >>>> + timer { >>>> + compatible = "arm,armv8-timer"; >>>> + interrupts = <1 13 0xff01>, >>>> + <1 14 0xff01>, >>>> + <1 11 0xff01>, >>>> + <1 10 0xff01>; >>>> + }; >>> >>> The Cortex-A57 TRM clearly states that these interrupts are level >>> triggered. >> >> Thanks for pointing this out. I¹ll fix this to <1 1X 0xff04> (4 for the >> Active-High) then. > > Hi Suravee, > > Don't know what Seattle does, but the TRM says that the outputs are active-LOW. As I said in another thread, 0xff04 *is* the right value. This is an interrupt descriptor for the GIC, not a qualifier for the signal that comes out of the core. Thanks. M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/