Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbaK0PjR (ORCPT ); Thu, 27 Nov 2014 10:39:17 -0500 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:49147 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbaK0PjM (ORCPT ); Thu, 27 Nov 2014 10:39:12 -0500 Date: Thu, 27 Nov 2014 15:34:15 +0000 From: One Thousand Gnomes To: Lyra Zhang Cc: Arnd Bergmann , Murali Karicheri , Chunyan Zhang , Grant Likely , "robh+dt@kernel.org" , Catalin Marinas , "gregkh@linuxfoundation.org" , "ijc+devicetree@hellion.org.uk" , "jslaby@suse.cz" , Kumar Gala , Mark Rutland , Pawel Moll , Ramkumar Ramachandra , "rrichter@cavium.com" , Will Deacon , Jonathan Corbet , "jason@lakedaemon.net" , Mark Brown , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , "florian.vaussard@epfl.ch" , "andrew@lunn.ch" , Hayato Suzuki , Orson Zhai , "geng.ren@spreadtrum.com" , "zhizhou.zhang" , "lanqing.liu@spreadtrum.com" , "Wei Qiao ( =?UTF-8?B?5LmU5Lyf?=)" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "sprdlinux@freelists.org" , "linux-doc@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support Message-ID: <20141127153415.3c2817b5@lxorguk.ukuu.org.uk> In-Reply-To: References: <1416917818-10506-1-git-send-email-chunyan.zhang@spreadtrum.com> <54761BFC.4020705@ti.com> <3400511.2SONqVcoEr@wuerfel> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.24; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes, I saw this way in other serial drivers. > But, if then, there are two questions for me: > 1. Why did some serial drivers need an UN_SHARED irq? > 2. How can we choose a right way? If your hardware can support sharing an IRQ then shared is the right way - along with the test Arnd suggested. Some hardware lacks the needed facilities to handle shared interrupt. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/