Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751113AbaK0WQs (ORCPT ); Thu, 27 Nov 2014 17:16:48 -0500 Received: from mail-ie0-f176.google.com ([209.85.223.176]:32820 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbaK0WQq convert rfc822-to-8bit (ORCPT ); Thu, 27 Nov 2014 17:16:46 -0500 MIME-Version: 1.0 In-Reply-To: <3124625.mkxyU0zW0C@wuerfel> References: <1416447994-9921-1-git-send-email-mark.yao@rock-chips.com> <5476CDF7.60208@rock-chips.com> <3124625.mkxyU0zW0C@wuerfel> Date: Thu, 27 Nov 2014 17:16:45 -0500 Message-ID: Subject: Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs From: Rob Clark To: Arnd Bergmann Cc: Daniel Kurtz , Mark yao , Dave Airlie , Joerg Roedel , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Boris BREZILLON , Daniel Vetter , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Grant Likely , Greg Kroah-Hartman , John Stultz , Rom Lemarchand , "devicetree@vger.kernel.org" , linux-doc@vger.kernel.org, LKML , dri-devel , linux-api@vger.kernel.org, "open list:ARM/Rockchip SoC..." , Douglas Anderson , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Dominik Behr , Olof Johansson , Eddie Cai , simon xue , Tao Huang , Kever Yang , =?UTF-8?B?6Zer5a2d5Yab?= , xw@rock-chips.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 27, 2014 at 4:56 PM, Arnd Bergmann wrote: > On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: >> On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote: >> > >> > On 2014年11月27日 10:12, Dave Airlie wrote: >> >>>> >> >>>> >> >>> Hi Dave >> >>> Do you mean that I need send you a branch, based on drm-next, merge with >> >>> iommu tree and rockchip drm? >> >> >> >> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's >> >> tree, put rockchip drm >> >> patches on top, send me pull request. >> >> >> >> I'll validate it then. >> >> >> >> Dave. >> >> >> > Hi Dave >> > I have send a pull request to you, with Joerg's iommu arm/rockchip branch. >> > >> > I got a same problem when use "make multi_v7_defconfig" as Heiko said: >> > drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! >> > drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER >> > drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP >> > drivers/gpu/drm/rockchip/Kconfig:1: symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU >> > arch/arm/Kconfig:95: symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3 >> > drivers/media/platform/Kconfig:96: symbol VIDEO_OMAP3 depends on VIDEO_V4L2 >> > drivers/media/v4l2-core/Kconfig:6: symbol VIDEO_V4L2 depends on I2C >> > drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC >> > drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC >> > drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 >> > drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 depends on FB >> > >> > I was confused how to solve the recursive dependency, remove depends on ARM_DMA_USE_IOMMU & IOMMU_API? >> >> The "depends on ARM_DMA_USE_IOMMU & IOMMU_API" was suggested by Arnd >> Bergmann during code review (originally they were selected). >> >> Removing them definitely fixes the dependency recursion. >> Also, since they are both already selected by ROCKCHIP_IOMMU, >> everything will build correctly. >> So, this sounds good to me, but I am no expert on Kconfig. >> > > I think the problem here is VIDEO_OMAP3 (among others), it should do the > same as rockchips and use 'depends on' instead of 'select'. > > Another problem is the 'select I2C' in FB_DDC, but that would be much harder > to fix. that 'select I2C' is the source of many loops.. I'd looked at it briefly before, but then ran away in despair. BR, -R > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/