Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502AbaK1LOP (ORCPT ); Fri, 28 Nov 2014 06:14:15 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:64525 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbaK1LOL (ORCPT ); Fri, 28 Nov 2014 06:14:11 -0500 Date: Fri, 28 Nov 2014 11:14:05 +0000 From: Mark Rutland To: Jacek Anaszewski Cc: "linux-leds@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kyungmin.park@samsung.com" , "b.zolnierkie@samsung.com" , "pavel@ucw.cz" , "cooloney@gmail.com" , "rpurdie@rpsys.net" , "sakari.ailus@iki.fi" , "s.nawrocki@samsung.com" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" Subject: Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property Message-ID: <20141128111404.GB25883@leverpostej> References: <1417166286-27685-1-git-send-email-j.anaszewski@samsung.com> <1417166286-27685-9-git-send-email-j.anaszewski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417166286-27685-9-git-send-email-j.anaszewski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 28, 2014 at 09:18:00AM +0000, Jacek Anaszewski wrote: > This patch adds a description of 'flashes' property > to the samsung-fimc.txt. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Sylwester Nawrocki > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: > --- > .../devicetree/bindings/media/samsung-fimc.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt > index 922d6f8..4b7ed03 100644 > --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt > +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt > @@ -40,6 +40,12 @@ should be inactive. For the "active-a" state the camera port A must be activated > and the port B deactivated and for the state "active-b" it should be the other > way around. > > +Optional properties: > + > +- flashes - array of strings with flash led names; the name has to > + be same with the related led label > + (see Documentation/devicetree/bindings/leds/common.txt) > + Why is this not an array of phandles to the LED nodes? That's much better than strings. Also, I only seem to have recevied the documentation patches and none of the code -- in future when posting RFC DT patches, please Cc for the code too as it's useful context. Mark. > The 'camera' node must include at least one 'fimc' child node. > > > @@ -166,6 +172,7 @@ Example: > clock-output-names = "cam_a_clkout", "cam_b_clkout"; > pinctrl-names = "default"; > pinctrl-0 = <&cam_port_a_clk_active>; > + flashes = "max77693-flash1", "max77693-flash2"; > status = "okay"; > #address-cells = <1>; > #size-cells = <1>; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/