Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751566AbaK1NjG (ORCPT ); Fri, 28 Nov 2014 08:39:06 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:63936 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbaK1NjD (ORCPT ); Fri, 28 Nov 2014 08:39:03 -0500 MIME-Version: 1.0 In-Reply-To: <1416837696-28066-1-git-send-email-alban.bedel@avionic-design.de> References: <1416837696-28066-1-git-send-email-alban.bedel@avionic-design.de> Date: Fri, 28 Nov 2014 14:39:01 +0100 Message-ID: Subject: Re: [PATCH 1/2] devicetree: add a binding for GPIOs going though a level shifter From: Linus Walleij To: Alban Bedel Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Grant Likely , Alexandre Courbot , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 24, 2014 at 3:01 PM, Alban Bedel wrote: > Signed-off-by: Alban Bedel > --- > .../devicetree/bindings/gpio/gpio-level-shifter.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-level-shifter.txt > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-level-shifter.txt b/Documentation/devicetree/bindings/gpio/gpio-level-shifter.txt > new file mode 100644 > index 0000000..e108c43 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-level-shifter.txt > @@ -0,0 +1,15 @@ > +GPIO level shifter > + > +This binding allow supporting GPIOs going though a level shifter. > + > +Required properties: > +- compatible : should be "gpio-level-shifter" > +- data-gpios : list of the data GPIO phandles > +- #gpio-cells : should be 2 > +- gpio-controller : marks the device node as a GPIO controller > + > +Optional properties: > +- enable-gpio : phandle of the GPIO that control the level shifter enable pin > +- direction-gpio : phandle of the GPIO that control the level shifter direction > +- vcca-supply : phandle of the regulator for side A of the level shifter > +- vccb-supply : phandle of the regulator for side B of the level shifter It must be clear which side is facing the parent GPIO controller, A or B. It must be clear which one of these two should be used if the level shifter has ony VCC. And isn't the proper terminology VCC+VDD? An example must be provided. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/