Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbaK1OCq (ORCPT ); Fri, 28 Nov 2014 09:02:46 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36057 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbaK1OCn (ORCPT ); Fri, 28 Nov 2014 09:02:43 -0500 MIME-Version: 1.0 In-Reply-To: <1416977280-27319-4-git-send-email-rebecca.swee.fun.chang@intel.com> References: <1416977280-27319-1-git-send-email-rebecca.swee.fun.chang@intel.com> <1416977280-27319-4-git-send-email-rebecca.swee.fun.chang@intel.com> Date: Fri, 28 Nov 2014 15:02:42 +0100 Message-ID: Subject: Re: [PATCHv4 3/3] gpio: sch: Enable IRQ support for Quark X1000 From: Linus Walleij To: Chang Rebecca Swee Fun Cc: Linux Kernel Mailing List , GPIO Subsystem Mailing List , Mika Westerberg , Denis Turischev , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 26, 2014 at 5:48 AM, Chang Rebecca Swee Fun wrote: > ntel Quark X1000 GPIO controller supports interrupt handling for > both core power well and resume power well. This patch is to enable > the IRQ support and provide IRQ handling for Intel Quark X1000 > GPIO-SCH device driver. > > This piece of work is derived from Dan O'Donovan's initial work for > Quark X1000 enabling. > > Signed-off-by: Chang Rebecca Swee Fun This is just adding handling of cascading interrupts from a GPIO chip as far as I can tell. We don't do that with local per-driver hacks anymore if there is no special reason, we have helpers on gpiolib to handle this. Make your Kconfig select GPIOLIB_IRQCHIP and take it from there, look at how other drivers using GPIOLIB_IRQCHIP are done. Read the documentation for chained irqchips in Documentation/gpio/driver.txt Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/