Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbaK1OO6 (ORCPT ); Fri, 28 Nov 2014 09:14:58 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:37729 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbaK1OO5 (ORCPT ); Fri, 28 Nov 2014 09:14:57 -0500 Date: Fri, 28 Nov 2014 17:14:32 +0300 From: Dan Carpenter To: Luis de Bethencourt Cc: devel@driverdev.osuosl.org, aaro.koskinen@iki.fi, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, eunb.song@samsung.com Subject: Re: [PATCH v2] staging: octeon: Fix checkpatch warnings Message-ID: <20141128141432.GG4860@mwanda> References: <20141127161432.GA32577@ks395439.kimsufi.com> <20141128102928.GD4860@mwanda> <20141128133034.GA4635@ks395439.kimsufi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141128133034.GA4635@ks395439.kimsufi.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 28, 2014 at 02:30:34PM +0100, Luis de Bethencourt wrote: > On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote: > > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote: > > > Fixing 80 character limit warnings in octeon/ethernet-rx.c > > > > > > Signed-off-by: Luis de Bethencourt > > > --- > > > drivers/staging/octeon/ethernet-rx.c | 51 +++++++++++++++++++++++++----------- > > > 1 file changed, 35 insertions(+), 16 deletions(-) > > > > > > diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c > > > index 1789a12..e387eb1 100644 > > > --- a/drivers/staging/octeon/ethernet-rx.c > > > +++ b/drivers/staging/octeon/ethernet-rx.c > > > @@ -109,6 +109,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work) > > > int interface = cvmx_helper_get_interface_num(work->ipprt); > > > int index = cvmx_helper_get_interface_index_num(work->ipprt); > > > union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl; > > > + > > > > Do this in a separate patch. > > Will do within the hour. > :( You should always wait overnight or a few hours before sending a patch. It's not a race. Go slowly. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/