Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbaK1Pdb (ORCPT ); Fri, 28 Nov 2014 10:33:31 -0500 Received: from mail-ie0-f176.google.com ([209.85.223.176]:43471 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbaK1Pd3 (ORCPT ); Fri, 28 Nov 2014 10:33:29 -0500 MIME-Version: 1.0 In-Reply-To: <20141128152512.2152EC40884@trevor.secretlab.ca> References: <1417110967-16284-1-git-send-email-leif.lindholm@linaro.org> <1417110967-16284-3-git-send-email-leif.lindholm@linaro.org> <20141128004403.08D90C40A7F@trevor.secretlab.ca> <20141128113428.GM2361@bivouac.eciton.net> <20141128152512.2152EC40884@trevor.secretlab.ca> From: Grant Likely Date: Fri, 28 Nov 2014 15:33:08 +0000 X-Google-Sender-Auth: 17x4lykzgT3RdpPf4aUnzj8MqW4 Message-ID: Subject: Re: Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() To: Leif Lindholm Cc: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Mark Rutland , Rob Herring , Jean-Christophe PLAGNIOL-VILLARD , Ian Campbell , Andrew Lunn , "s.hauer@pengutronix.de" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 28, 2014 at 3:25 PM, Grant Likely wrote: > On Fri, 28 Nov 2014 11:34:28 +0000 > , Leif Lindholm > wrote: >> On Fri, Nov 28, 2014 at 12:44:03AM +0000, Grant Likely wrote: >> > > + separator = strchr(path, ':'); >> > > + if (separator && opts) >> > > + *opts = separator + 1; >> > > + >> > >> > What about when there are no opts? Do we require the caller to make sure >> > opts is NULL before calling the function (which sounds like a good >> > source of bugs) or do we clear it on successful return? >> > >> > I think if opts is passed in, but there are no options, then it should >> > set *opts = NULL. >> >> Yeah, oops. >> >> > There should be test cases for this also. Must set opts to NULL on >> > successful return, and (I think) should leave opts alone on an >> > unsuccessful search. >> >> I would actually argue for always nuking the opts - since that could >> (theoretically) prevent something working by accident in spite of >> error conditions. >> >> How about the below? > > Perfect, applied with one fixup below... And by the way, let me say well done on this patch. It is elegantly implemented within the framework already there. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/