Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbaK1RKq (ORCPT ); Fri, 28 Nov 2014 12:10:46 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:39307 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbaK1RKm (ORCPT ); Fri, 28 Nov 2014 12:10:42 -0500 Date: Fri, 28 Nov 2014 17:10:24 +0000 From: Russell King - ARM Linux To: Eduardo Valentin Cc: Linux PM , Viresh Kumar , Lukasz Majewski , devicetree@vger.kernel.org, Kukjin Kim , LKML , Rob Herring , linux-samsung-soc@vger.kernel.org, Grant Likely , Zhang Rui , Naveen Krishna Chatradhi , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv3 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer Message-ID: <20141128171024.GW3836@n2100.arm.linux.org.uk> References: <1417186410-24551-1-git-send-email-edubezval@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417186410-24551-1-git-send-email-edubezval@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 28, 2014 at 10:53:30AM -0400, Eduardo Valentin wrote: > diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c > index 3f5ad25..d4eaa1b 100644 > --- a/drivers/thermal/samsung/exynos_thermal_common.c > +++ b/drivers/thermal/samsung/exynos_thermal_common.c > @@ -371,9 +371,10 @@ int exynos_register_thermal(struct thermal_sensor_conf *sensor_conf) > th_zone->cool_dev[th_zone->cool_dev_size] = > cpufreq_cooling_register(&mask_val); > if (IS_ERR(th_zone->cool_dev[th_zone->cool_dev_size])) { > - dev_err(sensor_conf->dev, > - "Failed to register cpufreq cooling device\n"); > - ret = -EINVAL; > + ret = PTR_ERR(th_zone->cool_dev[th_zone->cool_dev_size]); > + if (ret != -EPROBE_DEFER) > + dev_err(sensor_conf->dev, > + "Failed to register cpufreq cooling device\n"); Something which bugs me quite a lot is when there is an error code (which tells you why something didn't work) and you have an error message, and the error message doesn't bother printing the error code. You might as well just print "Failed\n" and leave it at that, or md5sum the error message and print the sum instead. :) Knowing why something failed allows you to read the source, and find possible reasons for the failure (which could come down to one reason) and allows faster resolution of the problem. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/