Date: Fri, 28 Nov 2014 11:15:07 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Javier =?iso-8859-1?Q?Gonz=E1lez?= <javier@javigon.com>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org,
        joshc@codeaurora.org, johannes.thumshirn@men.de,
        kheitke@codeaurora.org, laurent.pinchart+renesas@ideasonboard.com,
        geert+renesas@glider.be, horms+renesas@verge.net.au,
        damm@opensource.se, tomi.valkeinen@ti.com, mbohan@codeaurora.org,
        michal.simek@xilinx.com, pawel.moll@arm.com, Andrew.Thoelke@arm.com
Subject: Re: [RFC PATCH 1/3] Add generic TrustZone driver
Message-ID: <20141128191507.GA7804@kroah.com>
References: <1417187016-7731-1-git-send-email-javier@javigon.com>
 <1417187016-7731-2-git-send-email-javier@javigon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1417187016-7731-2-git-send-email-javier@javigon.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Nov 28, 2014 at 04:03:34PM +0100, Javier Gonz?lez wrote:
> From: Javier Gonzalez <javier@javigon.com>

Any reason you sent this twice?

And your code is full of FIXMEs, which implies that you aren't even
happy with the code, so why would we want to review it as-is now?

Please come up with a design, and implementation, that you feel
comfortable with before asking others to do work to review your broken
implementation.

> +static void trustzone_dev_release(struct device *dev)
> +{
> +	/* FIXME: You need to fix all this crap... */

Yes you do, why you are asking others to do your work is beyond my
comprehension...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/