Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbaK2QJD (ORCPT ); Sat, 29 Nov 2014 11:09:03 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:55380 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbaK2QJB (ORCPT ); Sat, 29 Nov 2014 11:09:01 -0500 From: OGAWA Hirofumi To: SF Markus Elfring Cc: Julia Lawall , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle Subject: Re: fs-fat: Less function calls in fat_fill_super() after error detection References: <5307CAA2.8060406@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5467B12C.4010602@users.sourceforge.net> <54796B5E.5040707@users.sourceforge.net> <87sih22sn8.fsf@devron.myhome.or.jp> <87lhmu2jl8.fsf@devron.myhome.or.jp> <5479DD48.6030508@users.sourceforge.net> Date: Sun, 30 Nov 2014 01:08:56 +0900 In-Reply-To: <5479DD48.6030508@users.sourceforge.net> (SF Markus Elfring's message of "Sat, 29 Nov 2014 15:50:48 +0100") Message-ID: <87egsm2dlz.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SF Markus Elfring writes: >> More labels are more chances of bug (and we don't care micro optimize >> on this error path), isn't it? > > I would prefer that a few jump targets can be redirected so that unnecessary > function calls (and corresponding checks) can be avoided. It is from real bugs in my experience, it saw several times those (mine and other guys, in linux and others). And I think it doesn't have value to maintain labels for micro optimization in *this error path* though. So, if you or analyzer can check bugs by the patches affect to those label usage in future, Acked-by: OGAWA Hirofumi -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/