Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751575AbaK2Re6 (ORCPT ); Sat, 29 Nov 2014 12:34:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48051 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbaK2Re4 (ORCPT ); Sat, 29 Nov 2014 12:34:56 -0500 Date: Sat, 29 Nov 2014 19:34:12 +0200 From: "Michael S. Tsirkin" To: Cornelia Huck Cc: linux-kernel@vger.kernel.org, David Miller , rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, Rusty Russell , Arnd Bergmann , Greg Kroah-Hartman , Amit Shah , Ohad Ben-Cohen , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Ashutosh Dixit , Nikhil Rao , Siva Yerramreddy , Joel Stanley , virtualization@lists.linux-foundation.org, lguest@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v6 02/46] virtio: use u32, not bitmap for features Message-ID: <20141129173412.GH22746@redhat.com> References: <1417118789-18231-1-git-send-email-mst@redhat.com> <1417118789-18231-3-git-send-email-mst@redhat.com> <20141128134457.37e427ce.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141128134457.37e427ce.cornelia.huck@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 28, 2014 at 01:44:57PM +0100, Cornelia Huck wrote: > On Thu, 27 Nov 2014 22:07:41 +0200 > "Michael S. Tsirkin" wrote: > > > It seemed like a good idea to use bitmap for features > > in struct virtio_device, but it's actually a pain, > > and seems to become even more painful when we get more > > than 32 feature bits. Just change it to a u32 for now. > > > > Based on patch by Rusty. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Rusty Russell > > Signed-off-by: Cornelia Huck > > Signed-off-by: Michael S. Tsirkin > > > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > > index d34ebfa..ab95a4c 100644 > > --- a/drivers/virtio/virtio_pci.c > > +++ b/drivers/virtio/virtio_pci.c > > @@ -120,8 +120,7 @@ static void vp_finalize_features(struct virtio_device *vdev) > > vring_transport_features(vdev); > > > > /* We only support 32 feature bits. */ > > I think you can kill this comment... Why? It's still true for virtio pci at this point, that's why we just do iowrite32 here. > > - BUILD_BUG_ON(ARRAY_SIZE(vdev->features) != 1); > > - iowrite32(vdev->features[0], vp_dev->ioaddr+VIRTIO_PCI_GUEST_FEATURES); > > + iowrite32(vdev->features, vp_dev->ioaddr+VIRTIO_PCI_GUEST_FEATURES); > > ...and add blanks around '+', as you're touching this line anyway. > > > } > > > > /* virtio config->get() implementation */ > > Reviewed-by: Cornelia Huck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/