Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751868AbaK3Bpl (ORCPT ); Sat, 29 Nov 2014 20:45:41 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:58035 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbaK3Bpj (ORCPT ); Sat, 29 Nov 2014 20:45:39 -0500 Message-ID: <1417311913.7215.111.camel@decadent.org.uk> Subject: Re: [PATCH] e1000: remove unused variables From: Ben Hutchings To: Hisashi T Fujinaka Cc: Sudip Mukherjee , Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Matthew Vick , John Ronciak , Mitch Williams , Linux NICS , e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 30 Nov 2014 01:45:13 +0000 In-Reply-To: References: <1417065728-5592-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-1PgVn7v+jBrWGgzV56qP" X-Mailer: Evolution 3.12.7-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:470:1f08:1539:1079:d8f7:d09f:54f7 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-1PgVn7v+jBrWGgzV56qP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote: > I'm pretty sure those double reads are there for a reason, so most of > this I'm going to have to check on Monday. We have a long holiday > weekend here in the US. [...] If there were double register reads being replaced with single register reads, I'd agree this was likely to introduce a regression. But all I see is var =3D er32(REG) being changed to er32(REG). Ben. --=20 Ben Hutchings The world is coming to an end. Please log off. --=-1PgVn7v+jBrWGgzV56qP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUAVHp2sOe/yOyVhhEJAQoGHw//SpO5726CRwxjBRtXTTFYjmOBzm2hki5j pnkeWfii7bo+kWP4LpeZ3OHmDUW1MiopoUqUGwZDevpWjlN+1M4OC0TKfQnYVi1Y sD/BFACNiNnynTDW9JiZLabHa0VPcMAHC0SjRenCcTNdlk+EryLTVynPui5/Ue+o Fi7xaNouGrUozxK+ScKMOtwC1deyoTRRYULmDK+m6f10oJKzVm7JgaxpBkBq4qHg irIIkHV2hvo52JOiEGJQOwCo241WyDR/7N72HqWR6JNWk/gdPHnQ41SJqZ22ZMar mhG+O1Kb/hCtkr99s91dQn6f0NbO4z1lzUVuxof3xRyppbyhstkO/lsM+KzLufEk qiuDcIaD0c0nW8m2GcZmVgqZYeDLT/FOfpbdVwaVwYrBrERtYwolMGS5lkeXYBDY dFrMwoqulFoMxwDfSg28b2NsqaAVc+jtYMec+G+kgQkKz22zno5sn4fsRWOkwio/ 4EkZ5E2zoqAfdEOmIa+jda9uzNbtfbhDhpPcfmBTbIomCGblsLuBowfXvAjw4Z60 ihuQiXBedQ0zpga9xw5ABT9dRQ98rL8pHcj0ORFLhiKWI3t26iiGr90LvEdSdWOZ ZyIclPRRbDjISe66CaAX5ugKetWqh6NBbM4P3AUS99rSIFb9/7Dfn0yHiDrjj9Ne R4r2BBJgc1c= =AvQD -----END PGP SIGNATURE----- --=-1PgVn7v+jBrWGgzV56qP-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/