Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 25 Dec 2002 16:38:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 25 Dec 2002 16:38:04 -0500 Received: from m83-mp1.cvx2-c.ren.dial.ntli.net ([62.252.152.83]:42229 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id ; Wed, 25 Dec 2002 16:38:03 -0500 Subject: Re: [PATCH] Fix CPU bitmask truncation From: Alan Cox To: Bjorn Helgaas Cc: William Lee Irwin III , Linus Torvalds , Linux Kernel Mailing List , Andreas Schwab In-Reply-To: <200212201000.21223.bjorn_helgaas@hp.com> References: <200212161213.29230.bjorn_helgaas@hp.com> <20021220103028.GB9704@holomorphy.com> <20021220111523.GA7644@holomorphy.com> <200212201000.21223.bjorn_helgaas@hp.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 (1.0.8-10) Date: 25 Dec 2002 21:43:08 +0000 Message-Id: <1040852588.1770.35.camel@dhcp22.swansea.linux.org.uk> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 17 On Fri, 2002-12-20 at 17:00, Bjorn Helgaas wrote: > This was an issue with gcc 2.96 on a 64-way IA64 box. I don't have > access to one at the moment, but as I remember, without the 2.4 changes: > > - ((p)->cpus_runnable & (p)->cpus_allowed & (1 << cpu)) > + ((p)->cpus_runnable & (p)->cpus_allowed & (1UL << cpu)) > > nothing would get scheduled on CPUs 32-63. I guess those changes > aren't controversial, though. Is this a C quirk or a compiler bug ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/