Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbaK3IzJ (ORCPT ); Sun, 30 Nov 2014 03:55:09 -0500 Received: from down.free-electrons.com ([37.187.137.238]:45338 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751846AbaK3IzH (ORCPT ); Sun, 30 Nov 2014 03:55:07 -0500 Date: Sun, 30 Nov 2014 09:55:00 +0100 From: Boris Brezillon To: Brian Norris Cc: David Woodhouse , linux-mtd@lists.infradead.org, Huang Shijie , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mike Voytovich , Roy Lee Subject: Re: [PATCH v5 1/3] mtd: nand: gpmi: add gpmi_move_bits function Message-ID: <20141130095500.16f75e05@bbrezillon> In-Reply-To: <20141130081110.GC3608@norris-Latitude-E6410> References: <1417020793-3354-1-git-send-email-boris.brezillon@free-electrons.com> <1417020793-3354-2-git-send-email-boris.brezillon@free-electrons.com> <20141126175708.1acb90ac@bbrezillon> <20141130081110.GC3608@norris-Latitude-E6410> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brian, On Sun, 30 Nov 2014 00:11:10 -0800 Brian Norris wrote: > On Wed, Nov 26, 2014 at 05:57:08PM +0100, Boris Brezillon wrote: > > On Wed, 26 Nov 2014 17:53:11 +0100 Boris Brezillon wrote: > > > +/** > > > + * gpmi_move_bits - move bits from one memory region to another > > > + * @dst: destination buffer > > > + * @dst_bit_off: bit offset we're starting to write at > > > + * @src: source buffer > > > + * @src_bit_off: bit offset we're starting to read from > > > + * @nbits: number of bits to copy > > > + * > > > + * This functions copies bits from one memory region to another, and is used by > > > + * the GPMI driver to copy ECC sections which are not guaranteed to be byte > > > + * aligned. > > > > I forgot to add that src and dst should not overlap, otherwise it won't > > work... > > Hmm, normally that's implied for copy-like operations. But since you > named this function "move" (rather than "copy" or "cpy"), that's a > little less clear. Indeed, that's a good point. > > Did you have a good reason for the "move" name? If not, maybe it's worth > changing. No, I don't, and I'd prefer changing the name than implementing a non destructive move function. I'll send a new version with this change. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/