Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbaK3T1d (ORCPT ); Sun, 30 Nov 2014 14:27:33 -0500 Received: from mout.gmx.net ([212.227.17.22]:55126 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbaK3T1c (ORCPT ); Sun, 30 Nov 2014 14:27:32 -0500 Message-ID: <547B6F9A.8030806@gmx.de> Date: Sun, 30 Nov 2014 20:27:22 +0100 From: Lino Sanfilippo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Julia Lawall CC: SF Markus Elfring , Olof Johansson , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/1] net-PA Semi: Deletion of unnecessary checks before the function call "pci_dev_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547A09B1.9090102@users.sourceforge.net> <547B579F.10709@gmx.de> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SeBGBVLr3aEA9O3VGEa8yGRaIwmhhO71PuuAhIrWnwDt+5cF727 DFaZXdP+I47jQu4Z5rMUc0XWzjM5Zi6xFrL9QnVnzglEacqd5TSUbcYAVcQUlJaMhA0bgE9 GNCASt11zl770g72qF3KC1X2PEUk66STNvqaUYSpmVnC3IAjNeORZ/Z+ONhXq4bxwbGhvRI hWM2a2UMRY/QiWwmTC9mw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.11.2014 18:47, Julia Lawall wrote: > > I have heard of at least one case where the problem you are raising > happened in practice... > > julia If one case is known then there are probably a lot more that have not been discovered yet. Maybe this topic should be clarified somewhere (e.g. in "CodingStyle")? On the other hand i always found it obvious that its the callers responsibility to only pass sane parameters to the called functions... Regards, Lino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/