Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbaK3Vn4 (ORCPT ); Sun, 30 Nov 2014 16:43:56 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:65191 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbaK3Vnz (ORCPT ); Sun, 30 Nov 2014 16:43:55 -0500 MIME-Version: 1.0 In-Reply-To: <1417359787-10138-45-git-send-email-mst@redhat.com> References: <1417359787-10138-1-git-send-email-mst@redhat.com> <1417359787-10138-45-git-send-email-mst@redhat.com> From: Prabhakar Lad Date: Sun, 30 Nov 2014 21:43:23 +0000 Message-ID: Subject: Re: [PATCH v7 44/46] virtio_scsi: export to userspace To: "Michael S. Tsirkin" Cc: LKML , David Miller , cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, Rusty Russell , Greg Kroah-Hartman , Alexei Starovoitov , Bjarke Istrup Pedersen , Andy Grover , stephen hemminger , Sakari Ailus , Anup Patel , linux-api , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, Thanks for the patch. On Sun, Nov 30, 2014 at 3:12 PM, Michael S. Tsirkin wrote: > Replace uXX by __uXX and _packed by __attribute((packed)) > as seems to be the norm for userspace headers. > > Signed-off-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > --- > include/uapi/linux/virtio_scsi.h | 74 ++++++++++++++++++++-------------------- > include/uapi/linux/Kbuild | 1 + Probably worth making a separate patch for this ? as it doesnt match with patch description aswel. Apart from that patch looks good. Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/