Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbaLAHWs (ORCPT ); Mon, 1 Dec 2014 02:22:48 -0500 Received: from mail-qa0-f47.google.com ([209.85.216.47]:54950 "EHLO mail-qa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbaLAHWq (ORCPT ); Mon, 1 Dec 2014 02:22:46 -0500 MIME-Version: 1.0 In-Reply-To: <20141129000417.GG30997@pd.tnic> References: <1417212867-25187-1-git-send-email-giedriuswork@gmail.com> <20141128231555.GA31468@pd.tnic> <547909CF.8060907@gmail.com> <20141129000417.GG30997@pd.tnic> Date: Mon, 1 Dec 2014 15:22:45 +0800 Message-ID: Subject: Re: [PATCH] platform: x86: hp_wireless: Inform the user if hp_wireless_input_setup()/add() fails From: Alex Hung To: Borislav Petkov Cc: Giedrius Statkevicius , Darren Hart , "platform-driver-x86@vger.kernel.org" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I think adding a pr_err message has a benefit - if kernel prints this message, a develop can quickly identify where it gets wrong by a string search on entire kernel source code. Other than this, both solutions are great. On Sat, Nov 29, 2014 at 8:04 AM, Borislav Petkov wrote: > On Sat, Nov 29, 2014 at 01:48:31AM +0200, Giedrius Statkevicius wrote: >> On 2014.11.29 01:15, Borislav Petkov wrote: >> > On Sat, Nov 29, 2014 at 12:14:27AM +0200, Giedrius Statkevicius wrote: >> >> In hpwl_add() there is a unused variable err to which we assign the >> >> result of hp_wireless_input_setup() but we don't do anything depending >> >> on the result so print out a message that informs the user if add() >> >> (hp_wireless_input_setup()) fails since acpi_device_probe() doesn't >> >> print anything in this case. >> >> >> >> Signed-off-by: Giedrius Statkevicius >> >> --- >> >> drivers/platform/x86/hp-wireless.c | 3 +++ >> >> 1 file changed, 3 insertions(+) >> >> >> >> diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c >> >> index 415348f..4e4cc8b 100644 >> >> --- a/drivers/platform/x86/hp-wireless.c >> >> +++ b/drivers/platform/x86/hp-wireless.c >> >> @@ -85,6 +85,9 @@ static int hpwl_add(struct acpi_device *device) >> >> int err; >> >> >> >> err = hp_wireless_input_setup(); >> >> + if (err) >> >> + pr_err("Failed to setup hp wireless hotkeys\n"); >> >> + >> > >> > I don't think there's need for that. Just do: >> > >> > return hp_wireless_input_setup(); >> > >> > and drop err completely. >> > >> > The upper layer which calls the ->add() method should propagate the >> > error properly. >> Looking at other platform drivers code some add() methods do give >> information to the user via pr_{err,warn,info} macros, some don't. My >> first patch to deal with this just removed the err variable like you >> have wrote but Darren Hart and Rafael J. Wysocki commented that maybe it >> should be better to inform the user about this error. That is why >> probably there was a variable for this in the first place but probably >> the original author just forgot to add a pr_err(). > > Ah, I see. Original author added to CC. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- -- Cheers, Alex Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/