Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbaLAIrl (ORCPT ); Mon, 1 Dec 2014 03:47:41 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:53488 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbaLAIrj (ORCPT ); Mon, 1 Dec 2014 03:47:39 -0500 Date: Mon, 1 Dec 2014 00:47:35 -0800 From: Jeremiah Mahler To: Chase Southwood Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: change some printk calls to pr_err Message-ID: <20141201084735.GA2705@hudson.localdomain> Mail-Followup-To: Jeremiah Mahler , Chase Southwood , gregkh@linuxfoundation.org, abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1417410356-25504-1-git-send-email-chase.southwood@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417410356-25504-1-git-send-email-chase.southwood@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chase, On Sun, Nov 30, 2014 at 11:05:56PM -0600, Chase Southwood wrote: > There are a handful of calls to printk in ni_stc.h without specified log > levels, as well as one in ni_mio_common.c. This patch converts these > calls to pr_err() instead, so that they are now explicitly log level > ERR. > > Signed-off-by: Chase Southwood > --- > I tacked the change to ni_mio_common.c on to this patch since it's the same > exact change and it's just one line, so I think a single patch is justified > here. > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- > drivers/staging/comedi/drivers/ni_stc.h | 14 +++++++------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > index 353c17b..11e7017 100644 > --- a/drivers/staging/comedi/drivers/ni_mio_common.c > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c > @@ -3945,7 +3945,7 @@ static unsigned ni_gpct_to_stc_register(enum ni_gpct_register reg) > stc_register = Interrupt_B_Enable_Register; > break; > default: > - printk("%s: unhandled register 0x%x in switch.\n", > + pr_err("%s: unhandled register 0x%x in switch.\n", > __func__, reg); > BUG(); > return 0; [...] On my system the default log level is 4 which corresponds to KERN_WARNING. So switching to pr_err() would change the log level of these messages. Using pr_warn() might be a better choice. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/