Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbaLAJUJ (ORCPT ); Mon, 1 Dec 2014 04:20:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42031 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719AbaLAJUG (ORCPT ); Mon, 1 Dec 2014 04:20:06 -0500 Date: Mon, 1 Dec 2014 11:19:40 +0200 From: "Michael S. Tsirkin" To: Ben Hutchings Cc: Sergei Shtylyov , linux-kernel@vger.kernel.org, David Miller , cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH v7 28/46] vhost: make features 64 bit Message-ID: <20141201091940.GB15607@redhat.com> References: <1417359787-10138-1-git-send-email-mst@redhat.com> <1417359787-10138-29-git-send-email-mst@redhat.com> <547B3B61.3090801@cogentembedded.com> <1417407157.7215.127.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417407157.7215.127.camel@decadent.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 01, 2014 at 04:12:37AM +0000, Ben Hutchings wrote: > On Sun, 2014-11-30 at 18:44 +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: > > > > > We need to use bit 32 for virtio 1.0 > > > > > Signed-off-by: Michael S. Tsirkin > > > Reviewed-by: Jason Wang > > > --- > > > drivers/vhost/vhost.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h > > > index 3eda654..c624b09 100644 > > > --- a/drivers/vhost/vhost.h > > > +++ b/drivers/vhost/vhost.h > > > @@ -106,7 +106,7 @@ struct vhost_virtqueue { > > > /* Protected by virtqueue mutex. */ > > > struct vhost_memory *memory; > > > void *private_data; > > > - unsigned acked_features; > > > + u64 acked_features; > > > /* Log write descriptors */ > > > void __user *log_base; > > > struct vhost_log *log; > > > @@ -174,6 +174,6 @@ enum { > > > > > > static inline int vhost_has_feature(struct vhost_virtqueue *vq, int bit) > > > { > > > - return vq->acked_features & (1 << bit); > > > + return vq->acked_features & (1ULL << bit); > > > > Erm, wouldn't the high word be just dropped when returning *int*? I think > > you need !!(vq->acked_features & (1ULL << bit)). > > Or change the return type to bool. > > Ben. > > -- > Ben Hutchings > The first rule of tautology club is the first rule of tautology club. Yes, I'll do that I think. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/