Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbaLAKqT (ORCPT ); Mon, 1 Dec 2014 05:46:19 -0500 Received: from service87.mimecast.com ([91.220.42.44]:59421 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbaLAKqR convert rfc822-to-8bit (ORCPT ); Mon, 1 Dec 2014 05:46:17 -0500 Date: Mon, 1 Dec 2014 10:46:13 +0000 From: Liviu Dudau To: Russell King - ARM Linux Cc: Rob Herring , Mark Rutland , Ian Campbell , Thomas Gleixner , Jason Cooper , Haojian Zhuang , Marc Zyngier , "devicetree@vger.kernel.org" , LKML , LAKML Subject: Re: [PATCH] irqchip: gic: Allow interrupt level to be set for PPIs. Message-ID: <20141201104612.GM828@e106497-lin.cambridge.arm.com> References: <1417197340-27298-1-git-send-email-Liviu.Dudau@arm.com> <20141201104145.GY3836@n2100.arm.linux.org.uk> MIME-Version: 1.0 In-Reply-To: <20141201104145.GY3836@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 01 Dec 2014 10:46:14.0099 (UTC) FILETIME=[07153A30:01D00D54] X-MC-Unique: 114120110461503001 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 01, 2014 at 10:41:45AM +0000, Russell King - ARM Linux wrote: > On Fri, Nov 28, 2014 at 05:55:40PM +0000, Liviu Dudau wrote: > > + /* > > + * PPIs are optionally configurable, but we cannot distinguish > > + * between high and low, nor falling and rising. Change the > > + * type so that it passes the next check. > > This comment could do with a /lot/ of improvement. It sounds like the > only reason this code exists is to bypass the check. If that's all > that's being done, there's better ways to code it. Hi Russell, You are right, all I want to do is bypass the next check because *if* the PPIs can be configured, then any combination is valid (edge raising/falling, level low/high). In real systems, PPIs tend to be configured with active level low. That falls the existing check. If I understood more your thoughts on improving the comment then I can try to come up with a better version. Best regards, Liviu > > -- > FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up > according to speedtest.net. > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/