Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbaLALEP (ORCPT ); Mon, 1 Dec 2014 06:04:15 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:41753 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbaLALEN (ORCPT ); Mon, 1 Dec 2014 06:04:13 -0500 Date: Mon, 1 Dec 2014 11:03:58 +0000 From: Russell King - ARM Linux To: Liviu Dudau Cc: Rob Herring , Mark Rutland , Ian Campbell , Thomas Gleixner , Jason Cooper , Haojian Zhuang , Marc Zyngier , "devicetree@vger.kernel.org" , LKML , LAKML Subject: Re: [PATCH] irqchip: gic: Allow interrupt level to be set for PPIs. Message-ID: <20141201110358.GA3836@n2100.arm.linux.org.uk> References: <1417197340-27298-1-git-send-email-Liviu.Dudau@arm.com> <20141201104145.GY3836@n2100.arm.linux.org.uk> <20141201104612.GM828@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141201104612.GM828@e106497-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 01, 2014 at 10:46:13AM +0000, Liviu Dudau wrote: > On Mon, Dec 01, 2014 at 10:41:45AM +0000, Russell King - ARM Linux wrote: > > On Fri, Nov 28, 2014 at 05:55:40PM +0000, Liviu Dudau wrote: > > > + /* > > > + * PPIs are optionally configurable, but we cannot distinguish > > > + * between high and low, nor falling and rising. Change the > > > + * type so that it passes the next check. > > > > This comment could do with a /lot/ of improvement. It sounds like the > > only reason this code exists is to bypass the check. If that's all > > that's being done, there's better ways to code it. > > Hi Russell, > > You are right, all I want to do is bypass the next check because *if* > the PPIs can be configured, then any combination is valid (edge > raising/falling, level low/high). In real systems, PPIs tend to be > configured with active level low. That falls the existing check. "fails" :) If all you want to do is to bypass the following check, what's wrong with actually doing that: - if (type != IRQ_TYPE_LEVEL_HIGH && type != IRQ_TYPE_EDGE_RISING) + if (gicirq >= 32 && type != IRQ_TYPE_LEVEL_HIGH && + type != IRQ_TYPE_EDGE_RISING) return -EINVAL; -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/