Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677AbaLARL6 (ORCPT ); Mon, 1 Dec 2014 12:11:58 -0500 Received: from mail-la0-f53.google.com ([209.85.215.53]:59565 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbaLARLz (ORCPT ); Mon, 1 Dec 2014 12:11:55 -0500 Message-ID: <547CA157.1080401@cogentembedded.com> Date: Mon, 01 Dec 2014 20:11:51 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: SF Markus Elfring , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547B4886.4080406@users.sourceforge.net> <547B496E.604@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> In-Reply-To: <547C82A6.2030808@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2014 06:00 PM, SF Markus Elfring wrote: >>> diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c >>> index 911b216..7e44212 100644 >>> --- a/drivers/net/ppp/ppp_mppe.c >>> +++ b/drivers/net/ppp/ppp_mppe.c >>> @@ -238,8 +238,7 @@ static void *mppe_alloc(unsigned char *options, int optlen) >>> return (void *)state; >>> >>> out_free: >>> - if (state->sha1_digest) >>> - kfree(state->sha1_digest); >>> + kfree(state->sha1_digest); >> Please keep this line aligned to the others. > Can it be that the previous source code contained unwanted space > characters at this place? Yes, it seems so. > Do you want indentation fixes as a separate update step? Yes, that would be better to keep it separate. > Regards, > Markus WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/