Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754143AbaLATEE (ORCPT ); Mon, 1 Dec 2014 14:04:04 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:61076 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbaLATEC (ORCPT ); Mon, 1 Dec 2014 14:04:02 -0500 MIME-Version: 1.0 In-Reply-To: References: <1417100556-7096-1-git-send-email-mathieu.magnaudet@enac.fr> Date: Mon, 1 Dec 2014 20:04:01 +0100 Message-ID: Subject: Re: [PATCH] hid: export hid_report_len as an inline function in hid.h From: David Herrmann To: Benjamin Tissoires Cc: Mathieu Magnaudet , Jiri Kosina , Benjamin Tissoires , linux-input , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Mon, Dec 1, 2014 at 7:22 PM, Benjamin Tissoires wrote: > On Thu, Nov 27, 2014 at 10:02 AM, Mathieu Magnaudet > wrote: >> in several hid drivers it is necessary to calculate the length >> of an hid_report. This patch exports the existing static function >> hid_report_len of hid-core.c as an inline function in hid.h >> >> Signed-off-by: Mathieu Magnaudet >> --- > > IIRC, there are a few more custom report length computations > throughout the HID tree. They are not straightforward to convert, so I > think we have a pretty good start here. > > Reviewed-by: Benjamin Tissoires I fully agree! Reviewed-by: David Herrmann Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/