Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932498AbaLAVQh (ORCPT ); Mon, 1 Dec 2014 16:16:37 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:53562 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932112AbaLAVQf (ORCPT ); Mon, 1 Dec 2014 16:16:35 -0500 Message-ID: <547CDA61.40905@linaro.org> Date: Mon, 01 Dec 2014 22:15:13 +0100 From: Eric Auger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Christoffer Dall CC: eric.auger@st.com, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, alex.williamson@redhat.com, joel.schopp@amd.com, kim.phillips@freescale.com, paulus@samba.org, gleb@kernel.org, pbonzini@redhat.com, agraf@suse.de, linux-kernel@vger.kernel.org, patches@linaro.org, will.deacon@arm.com, a.motakis@virtualopensystems.com, a.rigo@virtualopensystems.com, john.liuli@huawei.com, ming.lei@canonical.com, feng.wu@intel.com Subject: Re: [PATCH v3 3/8] VFIO: platform: forwarded state tested when selecting IRQ handler References: <1416767760-14487-1-git-send-email-eric.auger@linaro.org> <1416767760-14487-4-git-send-email-eric.auger@linaro.org> <20141130124730.GD82106@macair> <547C7D9C.7030909@linaro.org> <20141201201057.GK23653@cbox> In-Reply-To: <20141201201057.GK23653@cbox> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2014 09:10 PM, Christoffer Dall wrote: > On Mon, Dec 01, 2014 at 03:39:24PM +0100, Eric Auger wrote: >> Hi Christoffer, >> On 11/30/2014 01:47 PM, Christoffer Dall wrote: >>> The subject reads strangely, perhaps just: >>> >>> VFIO: platform: test forward state when selecting IRQ handler >> OK >>> >>> On Sun, Nov 23, 2014 at 07:35:55PM +0100, Eric Auger wrote: >>>> In case the IRQ is forwarded, the VFIO platform IRQ handler does not >>>> need to disable the IRQ anymore. >>>> >>>> When setting the IRQ handler we now also test the forwarded state. In >>>> case the IRQ is forwarded we select the edge handler (no automaske). >>>> >>>> Signed-off-by: Eric Auger >>>> >>>> --- >>>> >>>> v2 -> v3: >>>> - forwarded state was tested in the handler. Now the forwarded state >>>> is tested before setting the handler. This definitively limits >>>> the dynamics of forwarded state changes but I don't think there is >>>> a use case where we need to be able to change the state at any time. >>> >>> user space can change this by calling the VFIO_IRQ_SET_ACTION_TRIGGER >>> whenever it wants, right? >> yes the user can set/unset the VFIO signaling (and request_irq/free_irq) >> using VFIO_IRQ_SET_ACTION_TRIGGER. In this new version I do not allow >> changing the forwarded state when the handler is attached (request_irq). >> >> Does it answer your interrogation? >> > interrogation? hopefully it wasn't that bad ;) Oups sorry "faux ami" in french. I wanted to say question but wanted to say it smarter. another time ;-) > > Yes, that answers my question. > > Thanks, > -Christoffer > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/