Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932761AbaLAXfb (ORCPT ); Mon, 1 Dec 2014 18:35:31 -0500 Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:60435 "HELO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754025AbaLAXf1 (ORCPT ); Mon, 1 Dec 2014 18:35:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <1416525081-27779-1-git-send-email-joestringer@nicira.com> From: Joe Stringer Date: Mon, 1 Dec 2014 15:35:01 -0800 Message-ID: Subject: Re: [PATCHv2 net] i40e: Implement ndo_gso_check() To: Jesse Gross Cc: netdev , Shannon Nelson , "Brandeburg, Jesse" , Jeff Kirsher , Tom Herbert , "linux.nics" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 November 2014 at 09:59, Joe Stringer wrote: > On 20 November 2014 16:19, Jesse Gross wrote: >> I don't know if we need to have the check at all for IPIP though - >> after all the driver doesn't expose support for it all (actually it >> doesn't expose GRE either). This raises kind of an interesting >> question about the checks though - it's pretty easy to add support to >> the driver for a new GSO type (and I imagine that people will be >> adding GRE soon) and forget to update the check. > > If the check is more conservative, then testing would show that it's > not working and lead people to figure out why (and update the check). More concretely, one suggestion would be something like following at the start of each gso_check(): + const int supported = SKB_GSO_TCPV4 | SKB_GSO_TCPV6 | SKB_GSO_FCOE | + SKB_GSO_UDP | SKB_GSO_UDP_TUNNEL; + + if (skb_shinfo(skb)->gso_type & ~supported) + return false; ..followed by checking the specifics for each. So far the patches have only been concerned with further checking on UDP tunnels. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/