Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932417AbaLBPuz (ORCPT ); Tue, 2 Dec 2014 10:50:55 -0500 Received: from bastet.se.axis.com ([195.60.68.11]:39192 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753902AbaLBPuy (ORCPT ); Tue, 2 Dec 2014 10:50:54 -0500 From: Rabin Vincent To: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, rabin@rab.in, Rabin Vincent Subject: [PATCH 3/3] perf: bench: fix memcpy/memset output Date: Tue, 2 Dec 2014 16:50:41 +0100 Message-Id: <1417535441-3965-3-git-send-email-rabin.vincent@axis.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1417535441-3965-1-git-send-email-rabin.vincent@axis.com> References: <1417535441-3965-1-git-send-email-rabin.vincent@axis.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The memcpy and memset benchmarks return bogus results when iterations > 0 because the iterations value is not taken into account when calculating the final result: $ perf bench mem memset --only-prefault --length 1GB --iterations 1 # Running 'mem/memset' benchmark: # Copying 1GB Bytes ... 20.798669 GB/Sec (with prefault) $ perf bench mem memset --only-prefault --length 1GB --iterations 10 # Running 'mem/memset' benchmark: # Copying 1GB Bytes ... 2.086576 GB/Sec (with prefault) $ perf bench mem memset --only-prefault --length 1GB --iterations 100 # Running 'mem/memset' benchmark: # Copying 1GB Bytes ... 212.840917 MB/Sec (with prefault) Fix this. Signed-off-by: Rabin Vincent --- tools/perf/bench/mem-memcpy.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c index e18be70..6c14afe 100644 --- a/tools/perf/bench/mem-memcpy.c +++ b/tools/perf/bench/mem-memcpy.c @@ -141,6 +141,7 @@ static int bench_mem_common(int argc, const char **argv, { int i; size_t len; + double totallen; double result_bps[2]; u64 result_cycle[2]; @@ -156,6 +157,7 @@ static int bench_mem_common(int argc, const char **argv, init_cycle(); len = (size_t)perf_atoll((char *)length_str); + totallen = (double)len * iterations; result_cycle[0] = result_cycle[1] = 0ULL; result_bps[0] = result_bps[1] = 0.0; @@ -219,10 +221,10 @@ static int bench_mem_common(int argc, const char **argv, if (use_cycle) { printf(" %14lf Cycle/Byte\n", (double)result_cycle[0] - / (double)len); + / totallen); printf(" %14lf Cycle/Byte (with prefault)\n", (double)result_cycle[1] - / (double)len); + / totallen); } else { print_bps(result_bps[0]); printf("\n"); @@ -233,7 +235,7 @@ static int bench_mem_common(int argc, const char **argv, if (use_cycle) { printf(" %14lf Cycle/Byte", (double)result_cycle[pf] - / (double)len); + / totallen); } else print_bps(result_bps[pf]); @@ -244,8 +246,8 @@ static int bench_mem_common(int argc, const char **argv, if (!only_prefault && !no_prefault) { if (use_cycle) { printf("%lf %lf\n", - (double)result_cycle[0] / (double)len, - (double)result_cycle[1] / (double)len); + (double)result_cycle[0] / totallen, + (double)result_cycle[1] / totallen); } else { printf("%lf %lf\n", result_bps[0], result_bps[1]); @@ -253,7 +255,7 @@ static int bench_mem_common(int argc, const char **argv, } else { if (use_cycle) { printf("%lf\n", (double)result_cycle[pf] - / (double)len); + / totallen); } else printf("%lf\n", result_bps[pf]); } @@ -324,7 +326,7 @@ static double do_memcpy_gettimeofday(const struct routine *r, size_t len, free(src); free(dst); - return (double)((double)len / timeval2double(&tv_diff)); + return (double)(((double)len * iterations) / timeval2double(&tv_diff)); } int bench_mem_memcpy(int argc, const char **argv, @@ -389,7 +391,7 @@ static double do_memset_gettimeofday(const struct routine *r, size_t len, timersub(&tv_end, &tv_start, &tv_diff); free(dst); - return (double)((double)len / timeval2double(&tv_diff)); + return (double)(((double)len * iterations) / timeval2double(&tv_diff)); } static const char * const bench_mem_memset_usage[] = { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/